Patchwork MTD: Correct typo "MTD_DATAFLASH_VERIFY_WRITE".

login
register
mail settings
Submitter Robert P. J. Day
Date July 20, 2009, 1:19 a.m.
Message ID <alpine.LFD.2.00.0907192115420.18015@localhost>
Download mbox | patch
Permalink /patch/29992/
State New
Headers show

Comments

Robert P. J. Day - July 20, 2009, 1:19 a.m.
Fix the misspelling to match the actual config variable defined in
drivers/mtd/devi ces/Kconfig:

config MTD_DATAFLASH_WRITE_VERIFY
        bool "Verify DataFlash page writes"
        depends on MTD_DATAFLASH

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  you know, there's a *reason* i keep reporting these anomalies...


========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
"Kernel Newbie Corner" column @ linux.com:          http://cli.gs/WG6WYX
========================================================================
Artem Bityutskiy - July 21, 2009, 7:43 a.m.
Seems correct to me, I'll put it to l2-mtd-2.6.git, thanks.

CCint David who seem to introduced this in the following commit:

commit 8c64038e4c077b2b37c6b27d0c40c77a3ddfaeef
Author: David Brownell <dbrownell@users.sourceforge.net>
Date:   Wed Aug 6 21:55:14 2008 -0700

     [MTD] make dataflash write-verify be optional

     This adds a WRITE_VERIFY Kconfig option to the DataFlash driver,
     closely mirroring the similar NAND and ONENAND options, giving
     an option to disable some code that's currently always enabled.

     Removing this step probably saves a millisecond or so per page
     when writing data, which will add up quickly since these pages
     are small (the largest is 1 KiB).  It doesn't seem to add a
     lot in terms of reliability, and wouldn't detect errors which
     crop up when transferring data to the on-chip SRAM buffer.

     Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
     Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
     Acked-by: Andrew Victor <linux@maxim.org.za>
     Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

On 07/20/2009 04:19 AM, Robert P. J. Day wrote:
> Fix the misspelling to match the actual config variable defined in
> drivers/mtd/devi ces/Kconfig:
>
> config MTD_DATAFLASH_WRITE_VERIFY
>          bool "Verify DataFlash page writes"
>          depends on MTD_DATAFLASH
>
> Signed-off-by: Robert P. J. Day<rpjday@crashcourse.ca>
>
> ---
>
>    you know, there's a *reason* i keep reporting these anomalies...
>
> diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
> deleted file mode 100644
> index e69de29..0000000
> diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
> index 43976aa..70a7369 100644
> --- a/drivers/mtd/devices/mtd_dataflash.c
> +++ b/drivers/mtd/devices/mtd_dataflash.c
> @@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
>   		(void) dataflash_waitready(priv->spi);
>
>
> -#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
> +#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
>
>   		/* (3) Compare to Buffer1 */
>   		addr = pageaddr<<  priv->page_offset;
> @@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
>   		} else
>   			status = 0;
>
> -#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
> +#endif	/* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
>
>   		remaining = remaining - writelen;
>   		pageaddr++;
>
> ========================================================================
> Robert P. J. Day                               Waterloo, Ontario, CANADA
>
>          Linux Consulting, Training and Annoying Kernel Pedantry.
>
> Web page:                                          http://crashcourse.ca
> Twitter:                                       http://twitter.com/rpjday
> "Kernel Newbie Corner" column @ linux.com:          http://cli.gs/WG6WYX
> ========================================================================
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Patch

diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
deleted file mode 100644
index e69de29..0000000
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 43976aa..70a7369 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -401,7 +401,7 @@  static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		(void) dataflash_waitready(priv->spi);


-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY

 		/* (3) Compare to Buffer1 */
 		addr = pageaddr << priv->page_offset;
@@ -430,7 +430,7 @@  static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		} else
 			status = 0;

-#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif	/* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */

 		remaining = remaining - writelen;
 		pageaddr++;