Message ID | 1386692379-16648-1-git-send-email-zajec5@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
2013/12/10 Rafał Miłecki <zajec5@gmail.com>: > I've realized that I need to call ethtool command to get Ethernet > working after booting. Ex call: ethtool -s eth0 autoneg on > It was fixing Ethernet even if auto-negotiation was already on. > > Adding calls to phy_start and phy_stop look like a real solution. I kind of missed that too during the review, thanks for fixing this! I wonder if we could somehow issue a warning in libphy if we manage to go past ndo_start_xmit() and we have not yet started the PHY state machine. Acked-by: Florian Fainelli <f.fainelli@gmail.com> > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > --- > drivers/net/ethernet/broadcom/bgmac.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c > index db71d75..055204e 100644 > --- a/drivers/net/ethernet/broadcom/bgmac.c > +++ b/drivers/net/ethernet/broadcom/bgmac.c > @@ -1139,6 +1139,8 @@ static int bgmac_open(struct net_device *net_dev) > } > napi_enable(&bgmac->napi); > > + phy_start(bgmac->phy_dev); > + > netif_carrier_on(net_dev); > > err_out: > @@ -1151,6 +1153,8 @@ static int bgmac_stop(struct net_device *net_dev) > > netif_carrier_off(net_dev); > > + phy_stop(bgmac->phy_dev); > + > napi_disable(&bgmac->napi); > bgmac_chip_intrs_off(bgmac); > free_irq(bgmac->core->irq, net_dev); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Rafał Miłecki <zajec5@gmail.com> Date: Tue, 10 Dec 2013 17:19:39 +0100 > I've realized that I need to call ethtool command to get Ethernet > working after booting. Ex call: ethtool -s eth0 autoneg on > It was fixing Ethernet even if auto-negotiation was already on. > > Adding calls to phy_start and phy_stop look like a real solution. > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Applied. Please in the future make it clear what tree a patch is meant for, I assumed this is only for net-next so that's where I applied it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index db71d75..055204e 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1139,6 +1139,8 @@ static int bgmac_open(struct net_device *net_dev) } napi_enable(&bgmac->napi); + phy_start(bgmac->phy_dev); + netif_carrier_on(net_dev); err_out: @@ -1151,6 +1153,8 @@ static int bgmac_stop(struct net_device *net_dev) netif_carrier_off(net_dev); + phy_stop(bgmac->phy_dev); + napi_disable(&bgmac->napi); bgmac_chip_intrs_off(bgmac); free_irq(bgmac->core->irq, net_dev);
I've realized that I need to call ethtool command to get Ethernet working after booting. Ex call: ethtool -s eth0 autoneg on It was fixing Ethernet even if auto-negotiation was already on. Adding calls to phy_start and phy_stop look like a real solution. Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 4 ++++ 1 file changed, 4 insertions(+)