| Message ID | 1386680134-85452-2-git-send-email-yangyingliang@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Yang Yingliang <yangyingliang@huawei.com> Date: Tue, 10 Dec 2013 20:55:29 +0800 > return is not a function, parentheses are not required. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/act_api.c b/net/sched/act_api.c index fd70728..92a3c31 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -191,7 +191,8 @@ u32 tcf_hash_new_index(u32 *idx_gen, struct tcf_hashinfo *hinfo) val = 1; } while (tcf_hash_lookup(val, hinfo)); - return (*idx_gen = val); + *idx_gen = val; + return val; } EXPORT_SYMBOL(tcf_hash_new_index); diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c index 3886365..0952fd2 100644 --- a/net/sched/sch_dsmark.c +++ b/net/sched/sch_dsmark.c @@ -47,7 +47,7 @@ struct dsmark_qdisc_data { static inline int dsmark_valid_index(struct dsmark_qdisc_data *p, u16 index) { - return (index <= p->indices && index > 0); + return index <= p->indices && index > 0; } /* ------------------------- Class/flow operations ------------------------- */
return is not a function, parentheses are not required. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- net/sched/act_api.c | 3 ++- net/sched/sch_dsmark.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)