From patchwork Fri Jul 17 17:23:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 29928 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 04927B7257 for ; Sat, 18 Jul 2009 03:23:48 +1000 (EST) Received: by ozlabs.org (Postfix) id 7E955DDD1B; Sat, 18 Jul 2009 03:23:47 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 09543DDD0C for ; Sat, 18 Jul 2009 03:23:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932834AbZGQRXo (ORCPT ); Fri, 17 Jul 2009 13:23:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933470AbZGQRXo (ORCPT ); Fri, 17 Jul 2009 13:23:44 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54027 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbZGQRXo convert rfc822-to-8bit (ORCPT ); Fri, 17 Jul 2009 13:23:44 -0400 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id ADBAE35C163; Fri, 17 Jul 2009 10:23:48 -0700 (PDT) Date: Fri, 17 Jul 2009 10:23:48 -0700 (PDT) Message-Id: <20090717.102348.267553979.davem@davemloft.net> To: joel.bertrand@systella.fr Cc: sparclinux@vger.kernel.org Subject: Re: [2.6.29.4] Blade 2000 From: David Miller In-Reply-To: <4A3F5E2D.4070202@systella.fr> References: <20090622.001359.165441240.davem@davemloft.net> <20090622.015657.175032843.davem@davemloft.net> <4A3F5E2D.4070202@systella.fr> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org From: BERTRAND Joël Date: Mon, 22 Jun 2009 12:34:21 +0200 > When I've tried to investigate, kernel oopses : This will fix the oops, but not the probe failure: sparc: Fix cleanup crash in bbc_envctrl_cleanup() If kthread_run() fails or never gets to run we'll have NULL or a pointer encoded error in kenvctrld_task, rather than a legitimate task pointer. So this makes bbc_envctrl_cleanup() crash as it passed this bogus pointer into kthread_stop(). Reported-by: BERTRAND Joël Signed-off-by: David S. Miller --- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/sbus/char/bbc_envctrl.c b/drivers/sbus/char/bbc_envctrl.c index 15dab96..7c815d3 100644 --- a/drivers/sbus/char/bbc_envctrl.c +++ b/drivers/sbus/char/bbc_envctrl.c @@ -537,8 +537,12 @@ int bbc_envctrl_init(struct bbc_i2c_bus *bp) } if (temp_index != 0 && fan_index != 0) { kenvctrld_task = kthread_run(kenvctrld, NULL, "kenvctrld"); - if (IS_ERR(kenvctrld_task)) - return PTR_ERR(kenvctrld_task); + if (IS_ERR(kenvctrld_task)) { + int err = PTR_ERR(kenvctrld_task); + + kenvctrld_task = NULL; + return err; + } } return 0; @@ -561,7 +565,8 @@ void bbc_envctrl_cleanup(struct bbc_i2c_bus *bp) struct bbc_cpu_temperature *tp, *tpos; struct bbc_fan_control *fp, *fpos; - kthread_stop(kenvctrld_task); + if (kenvctrld_task) + kthread_stop(kenvctrld_task); list_for_each_entry_safe(tp, tpos, &bp->temps, bp_list) { list_del(&tp->bp_list);