Patchwork pwclient: fix handling UTF-8 in patch info

login
register
mail settings
Submitter Andreas Bießmann
Date Dec. 9, 2013, 12:30 p.m.
Message ID <1386592253-6227-1-git-send-email-andreas@biessmann.de>
Download mbox | patch
Permalink /patch/299015/
State Accepted
Headers show

Comments

Andreas Bießmann - Dec. 9, 2013, 12:30 p.m.
This patch fixes following error when redirecting 'pwclient info' output:

---8<---
andreas@dockstar % pwclient info 295268 > /tmp/test.out
Traceback (most recent call last):
  File "/home/andreas/bin/pwclient", line 508, in <module>
    main()
  File "/home/andreas/bin/pwclient", line 471, in main
    action_info(rpc, patch_id)
  File "/home/andreas/bin/pwclient", line 242, in action_info
    print("- %- 14s: %s" % (key, value))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xdf' in position 29: ordinal not in range(128)
--->8---

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
 apps/patchwork/bin/pwclient |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jeremy Kerr - Jan. 28, 2014, 1 p.m.
Hi Andreas,

> This patch fixes following error when redirecting 'pwclient info' output:

Thanks, applied!


Jeremy

Patch

diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index 5fce359..0c0ccaf 100755
--- a/apps/patchwork/bin/pwclient
+++ b/apps/patchwork/bin/pwclient
@@ -231,7 +231,7 @@  def action_info(rpc, patch_id):
     print(s)
     print('-' * len(s))
     for key, value in sorted(patch.iteritems()):
-        print("- %- 14s: %s" % (key, value))
+        print("- %- 14s: %s" % (key, unicode(value).encode("utf-8")))
 
 def action_get(rpc, patch_id):
     patch = rpc.patch_get(patch_id)