[U-Boot] netbsd:fix documentation typo.

From: Kees Jongenburger <kees.jongenburger@gmail.com>

The documentation suggested the arguments where passed over r3-r6
while the code bellow simply does that over r0-r3.

Cc: Kumar Gala <galak@kernel.crashing.org>
---
 common/cmd_bootm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On
> Behalf Of Kees Jongenburger
> Sent: 09 December 2013 10:28
> To: u-boot@lists.denx.de
> Cc: Kees Jongenburger; Kumar Gala
> Subject: [U-Boot] [PATCH] netbsd:fix documentation typo.
> 
> From: Kees Jongenburger <kees.jongenburger@gmail.com>
> 
> The documentation suggested the arguments where passed over r3-r6 while the
> code bellow simply does that over r0-r3.

s/bellow/below/

> 
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
>  common/cmd_bootm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index
> ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char *
> const argv[],
> 
>  	/*
>  	 * NetBSD Stage-2 Loader Parameters:
> -	 *   r3: ptr to board info data
> -	 *   r4: image address
> -	 *   r5: console device
> -	 *   r6: boot args string
> +	 *   r0: ptr to board info data
> +	 *   r1: image address
> +	 *   r3: console device

You mean r2 here I believe.

Qais

> +	 *   r3: boot args string
>  	 */
>  	(*loader)(gd->bd, os_hdr, consdev, cmdline);
> 
> --
> 1.8.3.2
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

hi Kees,

On Mon Dec 09, 2013 at 11:28:05AM +0100, Kees Jongenburger wrote:
> From: Kees Jongenburger <kees.jongenburger@gmail.com>
> 
> The documentation suggested the arguments where passed over r3-r6
> while the code bellow simply does that over r0-r3.
> 
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
>  common/cmd_bootm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
>  
>  	/*
>  	 * NetBSD Stage-2 Loader Parameters:
> -	 *   r3: ptr to board info data
> -	 *   r4: image address
> -	 *   r5: console device
> -	 *   r6: boot args string
> +	 *   r0: ptr to board info data
> +	 *   r1: image address
> +	 *   r3: console device
> +	 *   r3: boot args string

Umm, is this not supposed to be processor agnostic -- different
architectures would use different registers to pass these arguments. I
would suggest changing it to something like arg[0-3] instead.

-sughosh

Hi,

On 12/12/2013 10:23 AM, Sughosh Ganu wrote:
> hi Kees,
>
>   	 * NetBSD Stage-2 Loader Parameters:
> -	 *   r3: ptr to board info data
> -	 *   r4: image address
> -	 *   r5: console device
> -	 *   r6: boot args string
> +	 *   r0: ptr to board info data
> +	 *   r1: image address
> +	 *   r3: console device
> +	 *   r3: boot args string
> Umm, is this not supposed to be processor agnostic -- different
> architectures would use different registers to pass these arguments. I
> would suggest changing it to something like arg[0-3] instead.
Thanks for the feedback. I will wait a little more and update the patch.


Greetings