diff mbox

[v2] sh_eth: add R8A7791 support

Message ID 201312080259.19163.sergei.shtylyov@cogentembedded.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Sergei Shtylyov Dec. 7, 2013, 11:59 p.m. UTC
Add support for yet another ARM member of the R-Car family, R-Car M2, also known
as R8A7791 -- it will share the code and data with previously added R8A7790.
Despite the Ether devices in these SoCs are indistinguishable at least from the
driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
for the Renesas SoCs.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is atop of DaveM's 'net-next.git' repo.

Changes in version 2:
- added a new platform device ID for R8A7791 instead of changing the existing ID
  for R8A7790 to a R8A779x wildcard ID.

 drivers/net/ethernet/renesas/Kconfig  |    2 +-
 drivers/net/ethernet/renesas/sh_eth.c |    7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Dec. 11, 2013, 2:47 a.m. UTC | #1
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 8 Dec 2013 02:59:18 +0300

> Add support for yet another ARM member of the R-Car family, R-Car M2, also known
> as R8A7791 -- it will share the code and data with previously added R8A7790.
> Despite the Ether devices in these SoCs are indistinguishable at least from the
> driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
> unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
> for the Renesas SoCs.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Dec. 25, 2013, 7:14 a.m. UTC | #2
On Tue, Dec 10, 2013 at 09:47:54PM -0500, David Miller wrote:
> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date: Sun, 8 Dec 2013 02:59:18 +0300
> 
> > Add support for yet another ARM member of the R-Car family, R-Car M2, also known
> > as R8A7791 -- it will share the code and data with previously added R8A7790.
> > Despite the Ether devices in these SoCs are indistinguishable at least from the
> > driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
> > unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
> > for the Renesas SoCs.
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Applied, thank you.

Hi Sergei, Hi Dave,

I don't seem to be able to find this in net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Dec. 25, 2013, 11:05 a.m. UTC | #3
Hello.

On 25-12-2013 11:14, Simon Horman wrote:

>>> Add support for yet another ARM member of the R-Car family, R-Car M2, also known
>>> as R8A7791 -- it will share the code and data with previously added R8A7790.
>>> Despite the Ether devices in these SoCs are indistinguishable at least from the
>>> driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
>>> unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
>>> for the Renesas SoCs.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> Applied, thank you.

> Hi Sergei, Hi Dave,

> I don't seem to be able to find this in net-next.

http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=94a12b15e4c575e0aa0ba5e24a4f213163a823d0

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Dec. 25, 2013, 2:35 p.m. UTC | #4
On Wed, Dec 25, 2013 at 03:05:55PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 25-12-2013 11:14, Simon Horman wrote:
> 
> >>>Add support for yet another ARM member of the R-Car family, R-Car M2, also known
> >>>as R8A7791 -- it will share the code and data with previously added R8A7790.
> >>>Despite the Ether devices in these SoCs are indistinguishable at least from the
> >>>driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
> >>>unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
> >>>for the Renesas SoCs.
> 
> >>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>Applied, thank you.
> 
> >Hi Sergei, Hi Dave,
> 
> >I don't seem to be able to find this in net-next.
> 
> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=94a12b15e4c575e0aa0ba5e24a4f213163a823d0

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Dec. 26, 2013, 3:53 a.m. UTC | #5
From: Simon Horman <horms@verge.net.au>
Date: Wed, 25 Dec 2013 16:14:51 +0900

> On Tue, Dec 10, 2013 at 09:47:54PM -0500, David Miller wrote:
>> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Date: Sun, 8 Dec 2013 02:59:18 +0300
>> 
>> > Add support for yet another ARM member of the R-Car family, R-Car M2, also known
>> > as R8A7791 -- it will share the code and data with previously added R8A7790.
>> > Despite the Ether devices in these SoCs are indistinguishable at least from the
>> > driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
>> > unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
>> > for the Renesas SoCs.
>> > 
>> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> 
>> Applied, thank you.
> 
> Hi Sergei, Hi Dave,
> 
> I don't seem to be able to find this in net-next.

Check 'net', I might have put it there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Dec. 26, 2013, 5:38 a.m. UTC | #6
On Wed, Dec 25, 2013 at 10:53:30PM -0500, David Miller wrote:
> From: Simon Horman <horms@verge.net.au>
> Date: Wed, 25 Dec 2013 16:14:51 +0900
> 
> > On Tue, Dec 10, 2013 at 09:47:54PM -0500, David Miller wrote:
> >> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >> Date: Sun, 8 Dec 2013 02:59:18 +0300
> >> 
> >> > Add support for yet another ARM member of the R-Car family, R-Car M2, also known
> >> > as R8A7791 -- it will share the code and data with previously added R8A7790.
> >> > Despite the Ether devices in these SoCs are indistinguishable at least from the
> >> > driver's point of view, we do introduce a new platform device ID "r8a7791-ether"
> >> > unlike the wildcard ID used for R8A7778/9 SoCs, due to newly established policy
> >> > for the Renesas SoCs.
> >> > 
> >> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >> 
> >> Applied, thank you.
> > 
> > Hi Sergei, Hi Dave,
> > 
> > I don't seem to be able to find this in net-next.
> 
> Check 'net', I might have put it there.

Thanks, I have found it.

I had messed up my remotes and was looking in net instead of net-next.
It is present in net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: net-next/drivers/net/ethernet/renesas/Kconfig
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/Kconfig
+++ net-next/drivers/net/ethernet/renesas/Kconfig
@@ -13,4 +13,4 @@  config SH_ETH
 	  Renesas SuperH Ethernet device driver.
 	  This driver supporting CPUs are:
 		- SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757,
-		  R8A7740, R8A777x and R8A7790.
+		  R8A7740, R8A777x and R8A779x.
Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -395,8 +395,8 @@  static struct sh_eth_cpu_data r8a777x_da
 	.hw_swap	= 1,
 };
 
-/* R8A7790 */
-static struct sh_eth_cpu_data r8a7790_data = {
+/* R8A7790/1 */
+static struct sh_eth_cpu_data r8a779x_data = {
 	.set_duplex	= sh_eth_set_duplex,
 	.set_rate	= sh_eth_set_rate_r8a777x,
 
@@ -2807,7 +2807,8 @@  static struct platform_device_id sh_eth_
 	{ "sh7763-gether", (kernel_ulong_t)&sh7763_data },
 	{ "r8a7740-gether", (kernel_ulong_t)&r8a7740_data },
 	{ "r8a777x-ether", (kernel_ulong_t)&r8a777x_data },
-	{ "r8a7790-ether", (kernel_ulong_t)&r8a7790_data },
+	{ "r8a7790-ether", (kernel_ulong_t)&r8a779x_data },
+	{ "r8a7791-ether", (kernel_ulong_t)&r8a779x_data },
 	{ }
 };
 MODULE_DEVICE_TABLE(platform, sh_eth_id_table);