diff mbox

qxl: Add missing trace.h (fix broken build)

Message ID 1386425352-23728-1-git-send-email-sw@weilnetz.de
State Accepted
Headers show

Commit Message

Stefan Weil Dec. 7, 2013, 2:09 p.m. UTC
Commit ac86048bcd41129b18702ba63395f222871804de removed trace.h from
console.h and ignored the fact that qxl-render.c needs this file
(it includes qxl.h which includes console.h which included trace.h).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

Sorry for this regression. Obviously most builds don't set CONFIG_QXL.

Regards,
Stefan

 hw/display/qxl-render.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Michael Tokarev Dec. 7, 2013, 6:25 p.m. UTC | #1
07.12.2013 18:09, Stefan Weil wrote:
> Commit ac86048bcd41129b18702ba63395f222871804de removed trace.h from
> console.h and ignored the fact that qxl-render.c needs this file
> (it includes qxl.h which includes console.h which included trace.h).
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> Sorry for this regression. Obviously most builds don't set CONFIG_QXL.

I actually thought I enabled QXL in build when testing stuff initially.
However, as it turned out, I disabled it due to other reason, and forgot
about this...  Oh well.. ;)

Thanks, applied to trivial-patches queue.  I think an urgent pull request
is needed, unless this can be applied directly.

/mjt
diff mbox

Patch

diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
index d34b0c4..84f1367 100644
--- a/hw/display/qxl-render.c
+++ b/hw/display/qxl-render.c
@@ -20,6 +20,7 @@ 
  */
 
 #include "qxl.h"
+#include "trace.h"
 
 static void qxl_blit(PCIQXLDevice *qxl, QXLRect *rect)
 {