From patchwork Sat Dec 7 08:45:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 298636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AA3662C00A7 for ; Sat, 7 Dec 2013 19:45:55 +1100 (EST) Received: from localhost ([::1]:35018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDWL-0000aE-8R for incoming@patchwork.ozlabs.org; Sat, 07 Dec 2013 03:45:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDVu-0000WB-1u for qemu-devel@nongnu.org; Sat, 07 Dec 2013 03:45:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpDVs-0005Ns-7s for qemu-devel@nongnu.org; Sat, 07 Dec 2013 03:45:25 -0500 Received: from qemu.weilnetz.de ([2a03:4000:2:362::1]:52893 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDVs-0005No-1k; Sat, 07 Dec 2013 03:45:24 -0500 Received: by v2201305906712890.yourvserver.net (Postfix, from userid 1000) id A127C1802AD; Sat, 7 Dec 2013 09:45:21 +0100 (CET) From: Stefan Weil To: qemu-devel Date: Sat, 7 Dec 2013 09:45:21 +0100 Message-Id: <1386405921-18219-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a03:4000:2:362::1 Cc: qemu-trivial@nongnu.org, Stefan Weil , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Anthony Liguori Subject: [Qemu-devel] [PATCH] ui/cocoa: Use macro ARRAY_SIZE were possible X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- Please note that I could not test this patch. Regards, Stefan ui/cocoa.m | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..2524f18 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -240,9 +240,8 @@ int keymap[] = static int cocoa_keycode_to_qemu(int keycode) { - if((sizeof(keymap)/sizeof(int)) <= keycode) - { - printf("(cocoa) warning unknow keycode 0x%x\n", keycode); + if (ARRAY_SIZE(keymap) <= keycode) { + printf("(cocoa) warning unknown keycode 0x%x\n", keycode); return 0; } return keymap[keycode];