Patchwork RFA: patch to fix 2 testsuite failures for LRA on PPC

login
register
mail settings
Submitter Alan Modra
Date Dec. 7, 2013, 12:53 a.m.
Message ID <20131207005259.GB17917@bubble.grove.modra.org>
Download mbox | patch
Permalink /patch/298595/
State New
Headers show

Comments

Alan Modra - Dec. 7, 2013, 12:53 a.m.
On Fri, Dec 06, 2013 at 05:23:28PM -0500, Vladimir Makarov wrote:
> On 12/6/2013, 2:40 PM, David Edelsohn wrote:
> >On Fri, Dec 6, 2013 at 2:02 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
> >>         * config/rs6000/rs600.md (*bswapdi2_64bit): Remove ?? from the
> >>         constraint.
> >
> >Okay, let's just remove the "??" modifier from the constraint.
> >
> >Thanks for your patience, explanations, and work on this, Vlad.
> >
> 
> Thanks, David.
> 
> Committed as rev. 205765.

/* -m32 -O2 -S -mlra */
long long swap64 (long long x)
{
  return __builtin_bswap64 (x);
}

Here too, I think.  OK to apply David?

	* config/rs6000/rs600.md (bswapdi2_32bit): Remove ?? from the
	constraint.
David Edelsohn - Dec. 7, 2013, 1:34 a.m.
On Fri, Dec 6, 2013 at 7:53 PM, Alan Modra <amodra@gmail.com> wrote:
> On Fri, Dec 06, 2013 at 05:23:28PM -0500, Vladimir Makarov wrote:
>> On 12/6/2013, 2:40 PM, David Edelsohn wrote:
>> >On Fri, Dec 6, 2013 at 2:02 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>> >>         * config/rs6000/rs600.md (*bswapdi2_64bit): Remove ?? from the
>> >>         constraint.
>> >
>> >Okay, let's just remove the "??" modifier from the constraint.
>> >
>> >Thanks for your patience, explanations, and work on this, Vlad.
>> >
>>
>> Thanks, David.
>>
>> Committed as rev. 205765.
>
> /* -m32 -O2 -S -mlra */
> long long swap64 (long long x)
> {
>   return __builtin_bswap64 (x);
> }
>
> Here too, I think.  OK to apply David?
>
>         * config/rs6000/rs600.md (bswapdi2_32bit): Remove ?? from the
>         constraint.

Okay.  We might as well change it in this location as well.

Thanks, David

Patch

Index: gcc/config/rs6000/rs6000.md
===================================================================
--- gcc/config/rs6000/rs6000.md	(revision 205767)
+++ gcc/config/rs6000/rs6000.md	(working copy)
@@ -2544,7 +2544,7 @@ 
 }")
 
 (define_insn "bswapdi2_32bit"
-  [(set (match_operand:DI 0 "reg_or_mem_operand" "=&r,Z,??&r")
+  [(set (match_operand:DI 0 "reg_or_mem_operand" "=&r,Z,&r")
 	(bswap:DI (match_operand:DI 1 "reg_or_mem_operand" "Z,r,r")))
    (clobber (match_scratch:SI 2 "=&b,&b,X"))]
   "!TARGET_POWERPC64 && (REG_P (operands[0]) || REG_P (operands[1]))"