diff mbox

[7/8] rt2x00: Use %pM conversion specifier

Message ID 1247734839-21394-1-git-send-email-klto@zhaw.ch
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Tobias Klauser July 16, 2009, 9 a.m. UTC
Use the %pM conversion specifier for printk instead of print_mac.

Signed-off-by: Tobias Klauser <klto@zhaw.ch>
---
 drivers/net/wireless/rt2x00/rt2800usb.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Comments

Ivo van Doorn July 16, 2009, 8:27 p.m. UTC | #1
On Thursday 16 July 2009, Tobias Klauser wrote:
> Use the %pM conversion specifier for printk instead of print_mac.
> 
> Signed-off-by: Tobias Klauser <klto@zhaw.ch>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800usb.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 3756166..da84afb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2224,10 +2224,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
>  	 */
>  	mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
>  	if (!is_valid_ether_addr(mac)) {
> -		DECLARE_MAC_BUF(macbuf);
> -
>  		random_ether_addr(mac);
> -		EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
> +		EEPROM(rt2x00dev, "MAC: %pM\n", mac);
>  	}
>  
>  	rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Luis Rodriguez July 16, 2009, 8:35 p.m. UTC | #2
On Thu, Jul 16, 2009 at 1:27 PM, Ivo van Doorn<ivdoorn@gmail.com> wrote:
> On Thursday 16 July 2009, Tobias Klauser wrote:
>> Use the %pM conversion specifier for printk instead of print_mac.
>>
>> Signed-off-by: Tobias Klauser <klto@zhaw.ch>
>
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

Johannes already has a patch for this posted which takes care of all of these.

http://marc.info/?l=linux-wireless&m=124767211929848&w=2

  Luis
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 3756166..da84afb 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -2224,10 +2224,8 @@  static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
 	 */
 	mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
 	if (!is_valid_ether_addr(mac)) {
-		DECLARE_MAC_BUF(macbuf);
-
 		random_ether_addr(mac);
-		EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac));
+		EEPROM(rt2x00dev, "MAC: %pM\n", mac);
 	}
 
 	rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);