From patchwork Fri Dec 6 20:39:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 298256 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5E3072C00A0 for ; Sat, 7 Dec 2013 07:40:03 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=XQFxr0rmx2XmAocWS MhftToGqx/nUa9UGUMFc3niyjDtUGAX3/wTMUw5fEgYcHiV0Qu1DaKaFCHv4Dbt7 dbx6F5aoORFlrusWvIaxXgtEp7Q7nX2Ai2+rJwBzVIhRbcN57VeC0v4K9Yg4qv7z rk/Ry5HZ8h1qXOpDBOMj3pIN8I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=bk718yALknZxRa5JEibag91 161I=; b=Vucivg5fuLT2oxqemMSRZYqtjceI3Bi0ejKaAhoZ9eVjJAXCi3pYWGy oCr82CkZv3AxpzKvXETX+a57trbWdn37JMZoeW6X9XYP3ZVXQJ75MnyikDMh9kBc SgS0H2u4aaoohvCYQNCl6J0u30xaOK7M+883JykQ5lXBsEeM1Weo= Received: (qmail 25877 invoked by alias); 6 Dec 2013 20:39:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 25866 invoked by uid 89); 6 Dec 2013 20:39:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2013 20:39:56 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB6KdnJb014106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Dec 2013 15:39:49 -0500 Received: from tucnak.zalov.cz (vpn1-5-23.ams2.redhat.com [10.36.5.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB6Kdl8q005051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Dec 2013 15:39:48 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id rB6KdkQe005723; Fri, 6 Dec 2013 21:39:46 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id rB6Kdk2F005722; Fri, 6 Dec 2013 21:39:46 +0100 Date: Fri, 6 Dec 2013 21:39:46 +0100 From: Jakub Jelinek To: Richard Biener Cc: Sergey Ostanevich , Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Masked load/store vectorization (take 6) Message-ID: <20131206203946.GW892@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20131022132658.GM30970@tucnak.zalov.cz> <20131023172220.GW30970@tucnak.zalov.cz> <20131024111439.GZ30970@tucnak.zalov.cz> <20131112142930.GT27813@tucnak.zalov.cz> <20131128230906.GX892@tucnak.redhat.com> <20131206132725.GN892@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131206132725.GN892@tucnak.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes On Fri, Dec 06, 2013 at 02:27:25PM +0100, Jakub Jelinek wrote: > > You can install that as cleanup now if you split it out (so hopefully > > no users creep back that make removing it impossible). > > Ok, will do. Here is that part, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2013-12-06 Jakub Jelinek * tree-data-ref.c (struct data_ref_loc_d): Replace pos field with ref. (get_references_in_stmt): Don't record operand addresses, but operands themselves. (find_data_references_in_stmt, graphite_find_data_references_in_stmt): Adjust for the pos -> ref change. Jakub --- gcc/tree-data-ref.c.jj 2013-11-28 16:01:05.674837413 +0100 +++ gcc/tree-data-ref.c 2013-12-06 18:31:35.496730632 +0100 @@ -4320,8 +4320,8 @@ compute_all_dependences (vecsafe_push (ref); } @@ -4386,16 +4386,16 @@ get_references_in_stmt (gimple stmt, vec { unsigned i, n; - op0 = gimple_call_lhs_ptr (stmt); + op0 = gimple_call_lhs (stmt); n = gimple_call_num_args (stmt); for (i = 0; i < n; i++) { - op1 = gimple_call_arg_ptr (stmt, i); + op1 = gimple_call_arg (stmt, i); - if (DECL_P (*op1) - || (REFERENCE_CLASS_P (*op1) && get_base_address (*op1))) + if (DECL_P (op1) + || (REFERENCE_CLASS_P (op1) && get_base_address (op1))) { - ref.pos = op1; + ref.ref = op1; ref.is_read = true; references->safe_push (ref); } @@ -4404,11 +4404,11 @@ get_references_in_stmt (gimple stmt, vec else return clobbers_memory; - if (*op0 - && (DECL_P (*op0) - || (REFERENCE_CLASS_P (*op0) && get_base_address (*op0)))) + if (op0 + && (DECL_P (op0) + || (REFERENCE_CLASS_P (op0) && get_base_address (op0)))) { - ref.pos = op0; + ref.ref = op0; ref.is_read = false; references->safe_push (ref); } @@ -4435,7 +4435,7 @@ find_data_references_in_stmt (struct loo FOR_EACH_VEC_ELT (references, i, ref) { dr = create_data_ref (nest, loop_containing_stmt (stmt), - *ref->pos, stmt, ref->is_read); + ref->ref, stmt, ref->is_read); gcc_assert (dr != NULL); datarefs->safe_push (dr); } @@ -4464,7 +4464,7 @@ graphite_find_data_references_in_stmt (l FOR_EACH_VEC_ELT (references, i, ref) { - dr = create_data_ref (nest, loop, *ref->pos, stmt, ref->is_read); + dr = create_data_ref (nest, loop, ref->ref, stmt, ref->is_read); gcc_assert (dr != NULL); datarefs->safe_push (dr); }