From patchwork Fri Dec 6 19:15:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 298220 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 538632C0077 for ; Sat, 7 Dec 2013 06:23:41 +1100 (EST) Received: from localhost ([::1]:33101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0zy-0007w9-QE for incoming@patchwork.ozlabs.org; Fri, 06 Dec 2013 14:23:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0zI-0007p9-Np for qemu-devel@nongnu.org; Fri, 06 Dec 2013 14:23:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp0zB-0008Ax-HN for qemu-devel@nongnu.org; Fri, 06 Dec 2013 14:22:56 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:46068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0zB-0008Al-9c; Fri, 06 Dec 2013 14:22:49 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id BEE4040DD1; Fri, 6 Dec 2013 23:22:47 +0400 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id BC2F952D; Fri, 6 Dec 2013 23:15:44 +0400 (MSK) Received: (nullmailer pid 19229 invoked by uid 1000); Fri, 06 Dec 2013 19:15:44 -0000 From: Michael Tokarev To: aliguori@amazon.com Date: Fri, 6 Dec 2013 23:15:37 +0400 Message-Id: <1386357341-19147-11-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1386357341-19147-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1386357341-19147-1-git-send-email-mjt@msgid.tls.msk.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 10/14] libcacard/cac: Remove unused statement (value stored is never read) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil Warning from ccc-analyzer: libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read ret = VCARD_DONE; ^ ~~~~~~~~~~ Here 'ret' is assigned a value inside of a switch statement and also after that switch statement. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- libcacard/cac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libcacard/cac.c b/libcacard/cac.c index 7a06b5a..74ef3e3 100644 --- a/libcacard/cac.c +++ b/libcacard/cac.c @@ -189,7 +189,6 @@ cac_applet_pki_process_apdu(VCard *card, VCardAPDU *apdu, pki_applet->sign_buffer = sign_buffer; pki_applet->sign_buffer_len = size; *response = vcard_make_response(VCARD7816_STATUS_SUCCESS); - ret = VCARD_DONE; break; case 0x00: /* we now have the whole buffer, do the operation, result will be