From patchwork Fri Dec 6 17:12:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejas Belagod X-Patchwork-Id: 298109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 30BB12C00A0 for ; Sat, 7 Dec 2013 04:12:30 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=a3B1sv78AVyUlLrQe zNZdMQZIxKGcC6MjPo5qydmwBr4FAmCvxGwxynVpBAhUu6PwuPq9iMdXUw6l12/N Cd8GgSypVT5b5lMWj6zNhd7sQan1cNEBXLItaG/bWB/GTAtk/xpp/AbTMfe8D+fX KhpSYSmtqHOX5aFUh7YIWMBqPA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=Zudkz+G7YLyW5LUTXU3EDuG HOKY=; b=VoeR04suru+RZCnB8ExGyD/VZxxjA00KkTxxInsc8X9aQK0mfTo25YP PGSoZ/QXQp7wZdzamapA3yfKBK0ASmHkCRQ7O3rP2sKzA2wakvmTxnOONaIZmwuT HwX1E9ovY26fgzA9HJhB8G9INO6FsLXyCDGLd9nrq+e6NxB4ThHw= Received: (qmail 3717 invoked by alias); 6 Dec 2013 17:12:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 3664 invoked by uid 89); 6 Dec 2013 17:12:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from Unknown (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2013 17:12:20 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 06 Dec 2013 17:12:10 +0000 Received: from [10.1.203.80] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 6 Dec 2013 17:12:09 +0000 Message-ID: <52A20568.3060005@arm.com> Date: Fri, 06 Dec 2013 17:12:08 +0000 From: Tejas Belagod User-Agent: Thunderbird 2.0.0.18 (X11/20081120) MIME-Version: 1.0 To: Jakub Jelinek CC: "H.J. Lu" , Bill Schmidt , "gcc-patches@gcc.gnu.org" , Richard Sandiford Subject: Re: [Patch, RTL] Eliminate redundant vec_select moves. References: <527A7612.2080406@arm.com> <877gcll9ht.fsf@talisman.default> <527BA073.30900@arm.com> <87zjpg1d5p.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> <527BD411.6060300@arm.com> <878uwwdnx0.fsf@talisman.default> <52962733.7030005@arm.com> <87r4a0c1ul.fsf@talisman.default> <529F5318.1030505@arm.com> <20131205223750.GB892@tucnak.redhat.com> In-Reply-To: <20131205223750.GB892@tucnak.redhat.com> X-MC-Unique: 113120617121008301 X-IsSubscribed: yes Jakub Jelinek wrote: > On Wed, Dec 04, 2013 at 08:14:43AM -0800, H.J. Lu wrote: >>> --- /dev/null >>> +++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c >>> @@ -0,0 +1,64 @@ >>> +/* { dg-do run } */ >>> +/* { dg-require-effective-target vect_float } */ >>> +/* { dg-options "-O3 -fdump-rtl-combine-details" } */ > > Please change dg-options to dg-additional-options, otherwise > it overrides the target basic vectorization options and thus > fails on i686-linux. > >>> +/* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target >>> aarch64*-*-* } } } */ >> Any particular reason why it doesn't work for x86? >> >>> +/* { dg-final { cleanup-rtl-dump "combine" } } */ > > You also need to add > > /* { dg-final { cleanup-tree-dump "vect" } } */ > > because all vectorizer tests dump *.vect dumps. Here is a patch, OK to commit? Thanks, Tejas. 2013-12-06 Tejas Belagod testsuite/ * gcc.dg/vect/vect-nop-move.c: Fix dg options. diff --git a/gcc/testsuite/gcc.dg/vect/vect-nop-move.c b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c index 1941933..98f72f1 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-nop-move.c +++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c @@ -1,6 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target vect_float } */ -/* { dg-options "-O3 -fdump-rtl-combine-details" } */ +/* { dg-additional-options "-fdump-rtl-combine-details" } */ extern void abort (void); @@ -62,3 +62,4 @@ main() /* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target aarch64*-*-* } } } */ /* { dg-final { cleanup-rtl-dump "combine" } } */ +/* { dg-final { cleanup-tree-dump "vect" } } */