Patchwork [RTL] Eliminate redundant vec_select moves.

login
register
mail settings
Submitter Tejas Belagod
Date Dec. 6, 2013, 5:12 p.m.
Message ID <52A20568.3060005@arm.com>
Download mbox | patch
Permalink /patch/298109/
State New
Headers show

Comments

Tejas Belagod - Dec. 6, 2013, 5:12 p.m.
Jakub Jelinek wrote:
> On Wed, Dec 04, 2013 at 08:14:43AM -0800, H.J. Lu wrote:
>>> --- /dev/null
>>> +++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
>>> @@ -0,0 +1,64 @@
>>> +/* { dg-do run } */
>>> +/* { dg-require-effective-target vect_float } */
>>> +/* { dg-options "-O3 -fdump-rtl-combine-details" } */
> 
> Please change dg-options to dg-additional-options, otherwise
> it overrides the target basic vectorization options and thus
> fails on i686-linux.
> 
>>> +/* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target
>>> aarch64*-*-* } } } */
>> Any particular reason why it doesn't work for x86?
>>
>>> +/* { dg-final { cleanup-rtl-dump "combine" } } */
> 
> You also need to add
> 
> /* { dg-final { cleanup-tree-dump "vect" } } */
> 
> because all vectorizer tests dump *.vect dumps.

Here is a patch, OK to commit?

Thanks,
Tejas.

2013-12-06  Tejas Belagod  <tejas.belagod@arm.com>

testsuite/
           * gcc.dg/vect/vect-nop-move.c: Fix dg options.
Jakub Jelinek - Dec. 6, 2013, 5:19 p.m.
On Fri, Dec 06, 2013 at 05:12:08PM +0000, Tejas Belagod wrote:
> 2013-12-06  Tejas Belagod  <tejas.belagod@arm.com>
> 
> testsuite/
>           * gcc.dg/vect/vect-nop-move.c: Fix dg options.

Ok, thanks.

> --- a/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
> @@ -1,6 +1,6 @@
>  /* { dg-do run } */ 
>  /* { dg-require-effective-target vect_float } */
> -/* { dg-options "-O3 -fdump-rtl-combine-details" } */
> +/* { dg-additional-options "-fdump-rtl-combine-details" } */
>  
>  extern void abort (void);
>  
> @@ -62,3 +62,4 @@ main()
>  
>  /* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target aarch64*-*-* } } } */
>  /* { dg-final { cleanup-rtl-dump "combine" } } */
> +/* { dg-final { cleanup-tree-dump "vect" } } */


	Jakub

Patch

diff --git a/gcc/testsuite/gcc.dg/vect/vect-nop-move.c b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
index 1941933..98f72f1 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-nop-move.c
@@ -1,6 +1,6 @@ 
 /* { dg-do run } */ 
 /* { dg-require-effective-target vect_float } */
-/* { dg-options "-O3 -fdump-rtl-combine-details" } */
+/* { dg-additional-options "-fdump-rtl-combine-details" } */
 
 extern void abort (void);
 
@@ -62,3 +62,4 @@  main()
 
 /* { dg-final { scan-rtl-dump "deleting noop move" "combine" { target aarch64*-*-* } } } */
 /* { dg-final { cleanup-rtl-dump "combine" } } */
+/* { dg-final { cleanup-tree-dump "vect" } } */