Patchwork physmap: probe for partitions parsers that we enable

login
register
mail settings
Submitter Florian Fainelli
Date July 15, 2009, 10:11 a.m.
Message ID <200907151211.31062.florian@openwrt.org>
Download mbox | patch
Permalink /patch/29805/
State New, archived
Headers show

Comments

Florian Fainelli - July 15, 2009, 10:11 a.m.
This patch makes the physmap driver probe for partitions
parsers that we configured in the kernel configuration
instead of a hard-coded partition parser list (cmdlinepart,
RedBoot).

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
Mike Frysinger - July 15, 2009, 11:23 a.m.
On Wed, Jul 15, 2009 at 06:11, Florian Fainelli wrote:
> This patch makes the physmap driver probe for partitions
> parsers that we configured in the kernel configuration
> instead of a hard-coded partition parser list (cmdlinepart,
> RedBoot).

i believe there was a thread on this list some time ago about how
forcing all maps to declare support partition types sucks.  be nice if
there was a mtd function to probe all available maps so we wouldnt
have to copy & paste this #ifdef mess everywhere.

> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -80,7 +80,17 @@ static const char *rom_probe_types[] = {
>                                        "map_rom",
>                                        NULL };
>  #ifdef CONFIG_MTD_PARTITIONS
> -static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
> +static const char *part_probe_types[] = {
> +#ifdef CONFIG_MTD_CMDLINE_PARTS
> +       "cmdlinepart",
> +#endif
> +#ifdef CONFIG_MTD_REDBOOT_PARTS
> +       "RedBoot",
> +#endif
> +#ifdef CONFIG_MTD_AR7_PARTS
> +       "ar7part",
> +#endif
> +       NULL };
>  #endif

me thinks you just broke support when redboot is a module.
cmdlinepart isnt allowed to be a module via Kconfig, but ar7 can be.
-mike

Patch

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index 29a9011..e314f0d 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -80,7 +80,17 @@  static const char *rom_probe_types[] = {
 					"map_rom",
 					NULL };
 #ifdef CONFIG_MTD_PARTITIONS
-static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
+static const char *part_probe_types[] = {
+#ifdef CONFIG_MTD_CMDLINE_PARTS
+	"cmdlinepart",
+#endif
+#ifdef CONFIG_MTD_REDBOOT_PARTS
+	"RedBoot",
+#endif
+#ifdef CONFIG_MTD_AR7_PARTS
+	"ar7part",
+#endif
+	NULL };
 #endif
 
 static int physmap_flash_probe(struct platform_device *dev)