From patchwork Tue Jul 14 18:52:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 29779 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id E52D8B7063 for ; Wed, 15 Jul 2009 04:52:45 +1000 (EST) Received: by ozlabs.org (Postfix) id CA48DDDDA1; Wed, 15 Jul 2009 04:52:45 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 53B28DDD0B for ; Wed, 15 Jul 2009 04:52:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751044AbZGNSwm (ORCPT ); Tue, 14 Jul 2009 14:52:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755625AbZGNSwm (ORCPT ); Tue, 14 Jul 2009 14:52:42 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60038 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbZGNSwm (ORCPT ); Tue, 14 Jul 2009 14:52:42 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4043) id 67217F0D46; Tue, 14 Jul 2009 20:52:41 +0200 (CEST) Date: Tue, 14 Jul 2009 20:52:41 +0200 From: Jan Kara To: Doug Hunley Cc: linux-ext4@vger.kernel.org, tytso@mit.edu Subject: Re: quick question on journal_checksum Message-ID: <20090714185241.GA30638@atrey.karlin.mff.cuni.cz> References: <7284e2210906121115r14c1cd52xa23a072009349759@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7284e2210906121115r14c1cd52xa23a072009349759@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, > If one specifies journal_checksum as a mount option for an ext4 > rootfs, it should show up in the output of 'mount', yes? I'm not > seeing it. > > My grub line: > kernel /boot/vmlinuz-2.6.30-gentoo-r1 rw vga=0x31B > video=vesafb:1280x1024-24,mtrr:3,ywrap hpet=force fastboot quiet > forcedeth.msi=1 forcedeth.msix=1 forcedeth.dma_64bit=1 root=/dev/md3 > rootfstype=ext4 rootflags=journal_checksum > > and the 'mount' output: > rootfs on / type rootfs (rw) > /dev/root on / type ext4 (rw,relatime,barrier=1,data=writeback) > > Is this related to barriers failing? From dmesg: > JBD: barrier-based sync failed on md3:8 - disabling barriers This is unrelated. It's a bug in how ext4 shows options in /proc/mounts. Attached patch should fix it. Ted, will you merge it please? Honza From 8ce9bf5627f0f4257d87a500594ebc1368fdd630 Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Tue, 14 Jul 2009 20:37:30 +0200 Subject: [PATCH] ext4: Show journal_checksum option We failed to show journal_checksum option in /proc/mounts. Fix it. Signed-off-by: Jan Kara --- fs/ext4/super.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 8f4f079..04fdaf1 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -846,6 +846,8 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) seq_puts(seq, test_opt(sb, BARRIER) ? "1" : "0"); if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) seq_puts(seq, ",journal_async_commit"); + else if (test_opt(sb, JOURNAL_CHECKSUM)) + seq_puts(seq, ",journal_checksum"); if (test_opt(sb, NOBH)) seq_puts(seq, ",nobh"); if (test_opt(sb, I_VERSION)) -- 1.6.0.2