From patchwork Mon Jul 13 13:49:51 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Kulkarni X-Patchwork-Id: 29732 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 652BBB7066 for ; Mon, 13 Jul 2009 23:50:35 +1000 (EST) Received: by ozlabs.org (Postfix) id 59C08DDDF4; Mon, 13 Jul 2009 23:50:35 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DC1CDDDDF0 for ; Mon, 13 Jul 2009 23:50:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbZGMNuV (ORCPT ); Mon, 13 Jul 2009 09:50:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755964AbZGMNuU (ORCPT ); Mon, 13 Jul 2009 09:50:20 -0400 Received: from rv-out-0506.google.com ([209.85.198.230]:39641 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755947AbZGMNuR (ORCPT ); Mon, 13 Jul 2009 09:50:17 -0400 Received: by rv-out-0506.google.com with SMTP id f6so638578rvb.1 for ; Mon, 13 Jul 2009 06:50:17 -0700 (PDT) Received: by 10.141.37.8 with SMTP id p8mr2657310rvj.239.1247493017560; Mon, 13 Jul 2009 06:50:17 -0700 (PDT) Received: from localhost.localdomain (c-68-35-150-144.hsd1.nm.comcast.net [68.35.150.144]) by mx.google.com with ESMTPS id g31sm23849436rvb.0.2009.07.13.06.50.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 13 Jul 2009 06:50:16 -0700 (PDT) From: Abhishek Kulkarni To: linux-kernel@vger.kernel.org Cc: ericvh@gmail.com, Abhishek Kulkarni , v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH] [net/9p]: default 9p transport module fix Date: Mon, 13 Jul 2009 07:49:51 -0600 Message-Id: <1247492991-26009-2-git-send-email-adkulkar@umail.iu.edu> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <1247492991-26009-1-git-send-email-adkulkar@umail.iu.edu> References: <1247492991-26009-1-git-send-email-adkulkar@umail.iu.edu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The default 9p transport module is not chosen unless an option parameter (any) is passed to mount, which thus returns a ENOPROTOSUPPORT. This fix moves the check out of parse_opts into p9_client_create. Signed-off-by: Abhishek Kulkarni --- :100644 100644 cc25e63... 787ccdd... M net/9p/client.c net/9p/client.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/9p/client.c b/net/9p/client.c index cc25e63..787ccdd 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -117,9 +117,6 @@ static int parse_opts(char *opts, struct p9_client *clnt) } } - if (!clnt->trans_mod) - clnt->trans_mod = v9fs_get_default_trans(); - kfree(options); return ret; } @@ -689,6 +686,9 @@ struct p9_client *p9_client_create(const char *dev_name, char *options) if (err < 0) goto error; + if (!clnt->trans_mod) + clnt->trans_mod = v9fs_get_default_trans(); + if (clnt->trans_mod == NULL) { err = -EPROTONOSUPPORT; P9_DPRINTK(P9_DEBUG_ERROR,