Patchwork move am79c961's probe function to .devinit.text

mail settings
Submitter Uwe Kleine-König
Date July 11, 2009, 8:52 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/29705/
State Not Applicable
Delegated to: David Miller
Headers show


Uwe Kleine-König - July 11, 2009, 8:52 p.m.
A pointer to am79c961_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <>
Cc: Roel Kluin <>
Cc: Russell King <>
Cc: Andrew Morton <>
 drivers/net/arm/am79c961a.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
index 627bc75..51b19f2 100644
--- a/drivers/net/arm/am79c961a.c
+++ b/drivers/net/arm/am79c961a.c
@@ -680,7 +680,7 @@  static const struct net_device_ops am79c961_netdev_ops = {
-static int __init am79c961_probe(struct platform_device *pdev)
+static int __devinit am79c961_probe(struct platform_device *pdev)
 	struct resource *res;
 	struct net_device *dev;