Patchwork [/,RESENT,#3] mtd: let include/linux/mtd/partitions.h stand on its own

login
register
mail settings
Submitter Nicolas Pitre
Date July 10, 2009, 6:51 p.m.
Message ID <alpine.LFD.2.00.0907101448360.3138@xanadu.home>
Download mbox | patch
Permalink /patch/29685/
State New, archived
Headers show

Comments

Nicolas Pitre - July 10, 2009, 6:51 p.m.
When declaring static MTD partitions in board specific code, only
including include/linux/mtd/partitions.h should suffice without
gcc nagging us with:

In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list
include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list
include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list
include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list

Signed-off-by: Nicolas Pitre <nico@marvell.com>
---

Hello?  Anybody home?
Mike Frysinger - July 10, 2009, 7:03 p.m.
On Fri, Jul 10, 2009 at 14:51, Nicolas Pitre wrote:
> When declaring static MTD partitions in board specific code, only
> including include/linux/mtd/partitions.h should suffice without
> gcc nagging us with:
>
> In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list
>
> Signed-off-by: Nicolas Pitre <nico@marvell.com>

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

but this probably wont help your patch get merged ... mtd patches tend
to languish :/
-mike
Florian Fainelli - July 10, 2009, 7:34 p.m.
Hi Nicolas,

Le Friday 10 July 2009 20:51:33 Nicolas Pitre, vous avez écrit :
> When declaring static MTD partitions in board specific code, only
> including include/linux/mtd/partitions.h should suffice without
> gcc nagging us with:
>
> In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:50: warning: its scope
> is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared
> inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct
> mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67:
> warning: 'struct mtd_info' declared inside parameter list
>
> Signed-off-by: Nicolas Pitre <nico@marvell.com>

Thanks for doing this, Martin and I had the same problem on Cobalt Microservers (MIPS).

> ---
>
> Hello?  Anybody home?
>
> diff --git a/include/linux/mtd/partitions.h
> b/include/linux/mtd/partitions.h index af6dcb9..b70313d 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -47,6 +47,8 @@ struct mtd_partition {
>  #define MTDPART_SIZ_FULL	(0)
>
>
> +struct mtd_info;
> +
>  int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *,
> int); int del_mtd_partitions(struct mtd_info *);
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
Artem Bityutskiy - July 11, 2009, 10:37 a.m.
On Fri, 2009-07-10 at 14:51 -0400, Nicolas Pitre wrote:
> When declaring static MTD partitions in board specific code, only
> including include/linux/mtd/partitions.h should suffice without
> gcc nagging us with:
> 
> In file included from arch/arm/mach-kirkwood/sheevaplug-setup.c:14:
> include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list
> include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list
> 
> Signed-off-by: Nicolas Pitre <nico@marvell.com>

I've put your patch to l2-mtd-2.6.git some time ago:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git?a=commit;h=6d2bca50119cb620f61809ddfcf2d7d416264400

Patch

diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
index af6dcb9..b70313d 100644
--- a/include/linux/mtd/partitions.h
+++ b/include/linux/mtd/partitions.h
@@ -47,6 +47,8 @@  struct mtd_partition {
 #define MTDPART_SIZ_FULL	(0)
 
 
+struct mtd_info;
+
 int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *, int);
 int del_mtd_partitions(struct mtd_info *);