Patchwork [qemu-kvm,RHEL7] Add support statement to -help output

login
register
mail settings
Submitter Eduardo Habkost
Date Dec. 4, 2013, 6:42 p.m.
Message ID <1386182548-27119-1-git-send-email-ehabkost@redhat.com>
Download mbox | patch
Permalink /patch/296604/
State New
Headers show

Comments

Eduardo Habkost - Dec. 4, 2013, 6:42 p.m.
Bugzilla: 972773
Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272

Add support statement to -help output, reporting direct qemu-kvm usage
as unsupported by Red Hat, and advising users to use libvirt instead.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 vl.c | 9 +++++++++
 1 file changed, 9 insertions(+)
Eric Blake - Dec. 4, 2013, 6:51 p.m.
On 12/04/2013 11:42 AM, Eduardo Habkost wrote:
> Bugzilla: 972773
> 
> Add support statement to -help output, reporting direct qemu-kvm usage
> as unsupported by Red Hat, and advising users to use libvirt instead.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Wrong list; this patch is too specific to Red Hat to go upstream.
Eduardo Habkost - Dec. 4, 2013, 6:53 p.m.
On Wed, Dec 04, 2013 at 11:51:17AM -0700, Eric Blake wrote:
> On 12/04/2013 11:42 AM, Eduardo Habkost wrote:
> > Bugzilla: 972773
> > 
> > Add support statement to -help output, reporting direct qemu-kvm usage
> > as unsupported by Red Hat, and advising users to use libvirt instead.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  vl.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> 
> Wrong list; this patch is too specific to Red Hat to go upstream.

Oops! Sorry! Used the wrong command alias when sending the message. :(
Paolo Bonzini - Dec. 18, 2013, 10:39 a.m.
Il 04/12/2013 19:42, Eduardo Habkost ha scritto:
> Bugzilla: 972773
> Brew scratch build: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6676272
> 
> Add support statement to -help output, reporting direct qemu-kvm usage
> as unsupported by Red Hat, and advising users to use libvirt instead.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 9b1738b..fdc8c65 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1995,9 +1995,17 @@ static void version(void)
>      printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
>  }
>  
> +static void print_rh_warning(void)
> +{
> +    printf("\nWARNING: Direct use of qemu-kvm from the command line is not supported by Red Hat.\n"
> +             "WARNING: Use libvirt as the stable management interface.\n"
> +             "WARNING: Some command line options listed here may not be available in future releases.\n\n");
> +}
> +
>  static void help(int exitcode)
>  {
>      version();
> +    print_rh_warning();
>      printf("usage: %s [options] [disk_image]\n\n"
>             "'disk_image' is a raw hard disk image for IDE hard disk 0\n\n",
>              error_get_progname());
> @@ -2012,6 +2020,7 @@ static void help(int exitcode)
>             "\n"
>             "When using -nographic, press 'ctrl-a h' to get some help.\n");
>  
> +    print_rh_warning();
>      exit(exitcode);
>  }
>  
> 

Wow, no whitelist anymore?!?!?

ACK

Paolo

Patch

diff --git a/vl.c b/vl.c
index 9b1738b..fdc8c65 100644
--- a/vl.c
+++ b/vl.c
@@ -1995,9 +1995,17 @@  static void version(void)
     printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n");
 }
 
+static void print_rh_warning(void)
+{
+    printf("\nWARNING: Direct use of qemu-kvm from the command line is not supported by Red Hat.\n"
+             "WARNING: Use libvirt as the stable management interface.\n"
+             "WARNING: Some command line options listed here may not be available in future releases.\n\n");
+}
+
 static void help(int exitcode)
 {
     version();
+    print_rh_warning();
     printf("usage: %s [options] [disk_image]\n\n"
            "'disk_image' is a raw hard disk image for IDE hard disk 0\n\n",
             error_get_progname());
@@ -2012,6 +2020,7 @@  static void help(int exitcode)
            "\n"
            "When using -nographic, press 'ctrl-a h' to get some help.\n");
 
+    print_rh_warning();
     exit(exitcode);
 }