diff mbox

[U-Boot] video: ipu_disp: Return a negative value on error

Message ID 1386158514-3988-1-git-send-email-festevam@gmail.com
State Accepted
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Fabio Estevam Dec. 4, 2013, 12:01 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

We should return a negative error number (-EINVAL) on error.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/video/ipu_disp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anatolij Gustschin Dec. 4, 2013, 12:30 p.m. UTC | #1 
Hi Fabio,

On Wed,  4 Dec 2013 10:01:54 -0200
Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> We should return a negative error number (-EINVAL) on error.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/video/ipu_disp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master. Thanks!

Anatolij
diff mbox

Patch

diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
index 22ac142..cefd2dc 100644
--- a/drivers/video/ipu_disp.c
+++ b/drivers/video/ipu_disp.c
@@ -889,7 +889,7 @@  int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
 	debug("panel size = %d x %d\n", width, height);
 
 	if ((v_sync_width == 0) || (h_sync_width == 0))
-		return EINVAL;
+		return -EINVAL;
 
 	adapt_panel_to_ipu_restricitions(&pixel_clk, width, height,
 					 h_start_width, h_end_width,