diff mbox

[U-Boot] config.mk: Do not include include/config.mk

Message ID 1386139167-5954-1-git-send-email-yamada.m@jp.panasonic.com
State Rejected
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Dec. 4, 2013, 6:39 a.m. UTC
Board configuration creates include/config.mk, which is included
from both $(TOPDIR)/Makefile and $(TOPDIR)/config.mk.
This is rudandant.

Because $(TOPDIR)/Makefile exports ARCH, CPU, BOARD, VENDOR, SOC,
$(TOPDIR)/config.mk does not need to include include/config.mk.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

Please see around line 158 of $(TOPDIR)/Makefile:

  # load ARCH, BOARD, and CPU configuration
  include $(obj)include/config.mk
  export  ARCH CPU BOARD VENDOR SOC

And see also around line 168 of $(TOPDIR)/config.mk:

  sinclude $(OBJTREE)/include/config.mk


 config.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Masahiro Yamada Dec. 4, 2013, 10:53 a.m. UTC | #1
Hi.

> Board configuration creates include/config.mk, which is included
> from both $(TOPDIR)/Makefile and $(TOPDIR)/config.mk.
> This is rudandant.
> 
> Because $(TOPDIR)/Makefile exports ARCH, CPU, BOARD, VENDOR, SOC,
> $(TOPDIR)/config.mk does not need to include include/config.mk.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

It turned out this patch does not work for Tegra.
Please ignore this.

Best Regards
Masahiro Yamada
diff mbox

Patch

diff --git a/config.mk b/config.mk
index d5b09a0..2ce5b84 100644
--- a/config.mk
+++ b/config.mk
@@ -165,7 +165,6 @@  else
 sinclude $(OBJTREE)/include/autoconf.mk
 endif
 endif
-sinclude $(OBJTREE)/include/config.mk
 
 # Some architecture config.mk files need to know what CPUDIR is set to,
 # so calculate CPUDIR before including ARCH/SOC/CPU config.mk files.