| Message ID | 1386087563-23059-1-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On Tue, Dec 3, 2013 at 2:19 PM, Fabio Estevam <fabio.estevam@freescale.com> wrote: > HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging. > > Configure them as active pins. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> ... > + imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads)); A single line comment here making it clear it is here for convenience would be good.
On 12/04/2013 12:19 AM, Fabio Estevam wrote: > HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging. > > Configure them as active pins. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > Please fix the typo 'HYNC' in the commit head. It should be 'HSYNC'. Regard, Liu Ying
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c index 7e5bdf7..7b8db08 100644 --- a/board/freescale/mx6sabresd/mx6sabresd.c +++ b/board/freescale/mx6sabresd/mx6sabresd.c @@ -120,6 +120,12 @@ iomux_v3_cfg_t const usdhc4_pads[] = { MX6_PAD_SD4_DAT7__SD4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL), }; +iomux_v3_cfg_t const di0_pads[] = { + MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK, /* DISP0_CLK */ + MX6_PAD_DI0_PIN2__IPU1_DI0_PIN02, /* DISP0_HSYNC */ + MX6_PAD_DI0_PIN3__IPU1_DI0_PIN03, /* DISP0_VSYNC */ +}; + static void setup_iomux_uart(void) { imx_iomux_v3_setup_multiple_pads(uart1_pads, ARRAY_SIZE(uart1_pads)); @@ -371,6 +377,8 @@ static void setup_display(void) struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR; int reg; + imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads)); + enable_ipu_clock(); imx_setup_hdmi();
HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging. Configure them as active pins. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++ 1 file changed, 8 insertions(+)