Patchwork pcnet_cs: add odd location support for write_asic function

login
register
mail settings
Submitter Ken Kawasaki
Date July 8, 2009, 12:09 p.m.
Message ID <20090708210924.2a486a84.ken_kawasaki@spring.nifty.jp>
Download mbox | patch
Permalink /patch/29590/
State Superseded
Delegated to: David Miller
Headers show

Comments

Ken Kawasaki - July 8, 2009, 12:09 p.m.
Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>

---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 8, 2009, 5:38 p.m.
From: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>
Date: Wed, 8 Jul 2009 21:09:24 +0900

> Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>

This patch is already in the patchwork queue for networking:

	http://patchwork.ozlabs.org/patch/29462/

What is this odd address support actually needed for?  You
should have provided this information in the commit message.

That's why I haven't bothered applying the patch yet, I don't
even know what needs it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c.orig	2009-06-27 10:15:47.000000000 +0900
+++ linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c	2009-07-04 10:32:44.000000000 +0900
@@ -886,9 +886,10 @@  static void write_asic(unsigned int ioad
 		outb_p(EE_ASIC|EE_CS|EE_DI|dataval, ee_addr);
 	}
 	// sync
-	outb(EE_ASIC|EE_CS, ee_addr);
-	outb(EE_ASIC|EE_CS|EE_CK, ee_addr);
-	outb(EE_ASIC|EE_CS, ee_addr);
+	dataval = (location & 1) ? EE_DO : 0;
+	outb(EE_ASIC|EE_CS|dataval, ee_addr);
+	outb(EE_ASIC|EE_CS|dataval|EE_CK, ee_addr);
+	outb(EE_ASIC|EE_CS|dataval, ee_addr);
 
 	for (i = 15; i >= 0; i--) {
 		dataval = (asic_data & (1 << i)) ? EE_ADOT : 0;