Message ID | 1385981368-2235-1-git-send-email-gustavo@zacarias.com.ar |
---|---|
State | Accepted |
Commit | e89e2154c82dfb320721b8ddd2f3f87543e85e30 |
Headers | show |
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/Config.in | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > diff --git a/package/Config.in b/package/Config.in > index e2ca8ee..a65ceac 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -86,9 +86,6 @@ source "package/bison/Config.in" > source "package/bsdiff/Config.in" > source "package/bustle/Config.in" > source "package/ccache/Config.in" > -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS > -source "package/coreutils/Config.in" > -endif Committed, thanks. I'm really starting to think we should get rid of BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, or atleast make it default y. Comments, anybody?
> Committed, thanks. > > I'm really starting to think we should get rid of > BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, or atleast make it default y. > > Comments, anybody? > I personally don't know exactly what busybox provides, this option is a simple way to make sure I don't compile any useless stuff... I'm in favor of keeping it or provide another way to find duplicates > -- > Bye, Peter Korsgaard > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
Dear Peter Korsgaard, On Tue, 03 Dec 2013 09:01:43 +0100, Peter Korsgaard wrote: > >>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > > --- > > package/Config.in | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > diff --git a/package/Config.in b/package/Config.in > > index e2ca8ee..a65ceac 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -86,9 +86,6 @@ source "package/bison/Config.in" > > source "package/bsdiff/Config.in" > > source "package/bustle/Config.in" > > source "package/ccache/Config.in" > > -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS > > -source "package/coreutils/Config.in" > > -endif > > Committed, thanks. > > I'm really starting to think we should get rid of > BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, or atleast make it default y. > > Comments, anybody? We've always said that it was important to keep this option so that newcomers don't enable things like coreutils, bash and so on, and use what I'd consider the default "Buildroot experience", i.e Busybox. What made you change your mind about this? Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: Hi, >> Comments, anybody? > We've always said that it was important to keep this option so that > newcomers don't enable things like coreutils, bash and so on, and use > what I'd consider the default "Buildroot experience", i.e Busybox. True. > What made you change your mind about this? It mainly dates back from when those busybox alternatives didn't get much testing, so were likely to fail. We default to having busybox enabled, but I don't think we really need to make it more difficult to use the alternatives. E.G. if we support bash/coreutils/.., then we should really support them.
On 12/03/2013 05:59 AM, Thomas Petazzoni wrote: >> Committed, thanks. >> >> I'm really starting to think we should get rid of >> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS, or atleast make it default y. >> >> Comments, anybody? > > We've always said that it was important to keep this option so that > newcomers don't enable things like coreutils, bash and so on, and use > what I'd consider the default "Buildroot experience", i.e Busybox. > > What made you change your mind about this? /me thinks he got some patch conflict or something like that :) We can always make it per-package in package/x/Config.in -> depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS to avoid those issues. For me it's default y whenever i use BR, however i have no strong opinion either way. Regards.
Dear Peter Korsgaard, On Tue, 03 Dec 2013 11:05:19 +0100, Peter Korsgaard wrote: > > We've always said that it was important to keep this option so that > > newcomers don't enable things like coreutils, bash and so on, and use > > what I'd consider the default "Buildroot experience", i.e Busybox. > > True. > > > What made you change your mind about this? > > It mainly dates back from when those busybox alternatives didn't get > much testing, so were likely to fail. We default to having busybox > enabled, but I don't think we really need to make it more difficult to > use the alternatives. > > E.G. if we support bash/coreutils/.., then we should really support > them. I definitely agree with this last part, but I don't see how "really supporting them" conflicts with the idea of hiding them by default to avoid having newcomers confused by these. If the amount of conflicts in package/Config.in is your concern, then I believe I agree with Gustavoz suggestion of moving the dependency on BUSYBOX_SHOW_OTHERS down to the individual package/<foo>/Config.in. Best regards, Thomas
On 12/03/2013 05:08 AM, Jeremy Rosen wrote: > I personally don't know exactly what busybox provides, this option is > a simple way to make sure I don't compile any useless stuff... > > I'm in favor of keeping it or provide another way to find duplicates Sometimes the busybox version is short of features and you need the full version even when keeping busybox around. With that being said you sometimes want to avoid the opposite too. On this patchset i've found there are many of the big packages required (and needed fixing) to get a nice (no warnings or error messages) booting system with the default skeleton, OTOH: coreutils, util-linux, some shell (bash), sysvinit, sysklogd, linux-pam (inherent for util-linux). And with those we still get a warning from util-linux's hostname not being feature complete (oh the irony, busybox hostname is, we need net-tools to replace it). And we're still lacking ifup/ifdown :) Regards.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > On 12/03/2013 05:08 AM, Jeremy Rosen wrote: >> I personally don't know exactly what busybox provides, this option is >> a simple way to make sure I don't compile any useless stuff... >> >> I'm in favor of keeping it or provide another way to find duplicates > Sometimes the busybox version is short of features and you need the full > version even when keeping busybox around. Exactly, like we're hiding bash/zsh even though the differences from busybox ash are pretty huge. Same for syslogd/sysvinit or vim. > With that being said you sometimes want to avoid the opposite too. On > this patchset i've found there are many of the big packages required > (and needed fixing) to get a nice (no warnings or error messages) > booting system with the default skeleton, OTOH: coreutils, util-linux, > some shell (bash), sysvinit, sysklogd, linux-pam (inherent for util-linux). > And with those we still get a warning from util-linux's hostname not > being feature complete (oh the irony, busybox hostname is, we need > net-tools to replace it). > And we're still lacking ifup/ifdown :) Which relate to the point about these options not getting a lot of testing.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: Hi, >> E.G. if we support bash/coreutils/.., then we should really support >> them. > I definitely agree with this last part, but I don't see how "really > supporting them" conflicts with the idea of hiding them by default to > avoid having newcomers confused by these. It's mainly about when the featureset significantly differs between busybox and the "full" variant. The question if the busybox version is "good enough" unfortunately is quite system/use case dependent.
diff --git a/package/Config.in b/package/Config.in index e2ca8ee..a65ceac 100644 --- a/package/Config.in +++ b/package/Config.in @@ -86,9 +86,6 @@ source "package/bison/Config.in" source "package/bsdiff/Config.in" source "package/bustle/Config.in" source "package/ccache/Config.in" -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS -source "package/coreutils/Config.in" -endif source "package/cvs/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/diffutils/Config.in" @@ -959,6 +956,7 @@ source "package/acl/Config.in" source "package/attr/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/bootutils/Config.in" +source "package/coreutils/Config.in" endif source "package/cpuload/Config.in" source "package/dsp-tools/Config.in"
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/Config.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)