diff mbox

adlib: fix patching of port I/O addresses

Message ID 1385975778-30022-1-git-send-email-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini Dec. 2, 2013, 9:16 a.m. UTC
Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
fixed the offsets in adlib_portio_list, but forgot the matching indices
in adlib_realizefn.

Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
"neozeed".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/audio/adlib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Gerd Hoffmann Dec. 2, 2013, 9:52 a.m. UTC | #1
On Mo, 2013-12-02 at 10:16 +0100, Paolo Bonzini wrote:
> Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
> fixed the offsets in adlib_portio_list, but forgot the matching indices
> in adlib_realizefn.
> 
> Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
> "neozeed".

Picked into audio queue.

thanks,
  Gerd
Hervé Poussineau Dec. 2, 2013, 9:57 p.m. UTC | #2
Paolo Bonzini a écrit :
> Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14)
> fixed the offsets in adlib_portio_list, but forgot the matching indices
> in adlib_realizefn.
> 
> Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by
> "neozeed".
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>

Hervé
diff mbox

Patch

diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
index bd8e9d9..e88d2dd 100644
--- a/hw/audio/adlib.c
+++ b/hw/audio/adlib.c
@@ -347,8 +347,8 @@  static void adlib_realizefn (DeviceState *dev, Error **errp)
     s->samples = AUD_get_buffer_size_out (s->voice) >> SHIFT;
     s->mixbuf = g_malloc0 (s->samples << SHIFT);
 
-    adlib_portio_list[1].offset = s->port;
-    adlib_portio_list[2].offset = s->port + 8;
+    adlib_portio_list[0].offset = s->port;
+    adlib_portio_list[1].offset = s->port + 8;
     portio_list_init (port_list, OBJECT(s), adlib_portio_list, s, "adlib");
     portio_list_add (port_list, isa_address_space_io(&s->parent_obj), 0);
 }