Message ID | 529BE620.8090004@huawei.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On 2013/12/2 9:45, Wang Weidong wrote: > rto_min should be smaller than rto_max while rto_max should be larger > than rto_min. so just add the check. > > Acked-by: Neil Horman <nhorman@tuxdriver.com> > Signed-off-by: Wang Weidong <wangweidong1@huawei.com> > --- > net/sctp/sysctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c > index 6b36561..7637e8e 100644 > --- a/net/sctp/sysctl.c > +++ b/net/sctp/sysctl.c > @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec_minmax, > .extra1 = &one, > - .extra2 = &timer_max > + .extra2 = &init_net.sctp.rto_max > }, > { > .procname = "rto_max", > @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = { > .maxlen = sizeof(unsigned int), > .mode = 0644, > .proc_handler = proc_dointvec_minmax, > - .extra1 = &one, > + .extra1 = &init_net.sctp.rto_min, > .extra2 = &timer_max > }, > { > Hi Neil, As you point out that in "[PATCH] sctp: make the max_burst min value to 1": > 1) You can also set the the max_burst via setsockopt, and so this would need to > be checked in that path as well. we can set the rto_min/rto_max via setsockopt. Should I check it in the path as well? Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/01/2013 08:45 PM, Wang Weidong wrote: > rto_min should be smaller than rto_max while rto_max should be larger > than rto_min. so just add the check. > > Acked-by: Neil Horman <nhorman@tuxdriver.com> > Signed-off-by: Wang Weidong <wangweidong1@huawei.com> > --- > net/sctp/sysctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c > index 6b36561..7637e8e 100644 > --- a/net/sctp/sysctl.c > +++ b/net/sctp/sysctl.c > @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec_minmax, > .extra1 = &one, > - .extra2 = &timer_max > + .extra2 = &init_net.sctp.rto_max > }, > { > .procname = "rto_max", > @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = { > .maxlen = sizeof(unsigned int), > .mode = 0644, > .proc_handler = proc_dointvec_minmax, > - .extra1 = &one, > + .extra1 = &init_net.sctp.rto_min, > .extra2 = &timer_max > }, > { > So, now if initial namespace change rto_min and rto_max, it limits the values that another namespace can set? I don't think so. If you are looking to fix an issue where rto_max may be set below rto_min, then do a separate proc_handler. -vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013/12/2 22:45, Vlad Yasevich wrote: > On 12/01/2013 08:45 PM, Wang Weidong wrote: >> rto_min should be smaller than rto_max while rto_max should be larger >> than rto_min. so just add the check. >> >> Acked-by: Neil Horman <nhorman@tuxdriver.com> >> Signed-off-by: Wang Weidong <wangweidong1@huawei.com> >> --- >> net/sctp/sysctl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c >> index 6b36561..7637e8e 100644 >> --- a/net/sctp/sysctl.c >> +++ b/net/sctp/sysctl.c >> @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = { >> .mode = 0644, >> .proc_handler = proc_dointvec_minmax, >> .extra1 = &one, >> - .extra2 = &timer_max >> + .extra2 = &init_net.sctp.rto_max >> }, >> { >> .procname = "rto_max", >> @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = { >> .maxlen = sizeof(unsigned int), >> .mode = 0644, >> .proc_handler = proc_dointvec_minmax, >> - .extra1 = &one, >> + .extra1 = &init_net.sctp.rto_min, >> .extra2 = &timer_max >> }, >> { >> > > So, now if initial namespace change rto_min and rto_max, it limits the > values that another namespace can set? I don't think so. Hm, you are right. I think we have two path to set the rto_min or rto_max: 1)systclt, 2)setsockopt In 2) we can make the assoc or sk rto_max smaller than rto_min. so we should a check in the sctp_setsockopt_rtoinfo or proc_handler. > > If you are looking to fix an issue where rto_max may be set below > rto_min, then do a separate proc_handler. I will try to add a separate proc_handler. Thanks. > > -vlad > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 6b36561..7637e8e 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = { .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = &one, - .extra2 = &timer_max + .extra2 = &init_net.sctp.rto_max }, { .procname = "rto_max", @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, - .extra1 = &one, + .extra1 = &init_net.sctp.rto_min, .extra2 = &timer_max }, {