diff mbox

[U-Boot,v2,1/4] mkimage: added 'static' specifier to match function's prototype.

Message ID 1385926992-17478-2-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass Dec. 1, 2013, 7:43 p.m. UTC 
From: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com>

This function should be declared static.

Signed-off-by: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v2:
- Correct checkpatch problems

 tools/mkimage.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tom Rini Dec. 16, 2013, 2:15 p.m. UTC | #1 
On Sun, Dec 01, 2013 at 12:43:09PM -0700, Simon Glass wrote:

> From: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com>
> 
> This function should be declared static.
> 
> Signed-off-by: Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 7f22101..e12bc31 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -632,8 +632,7 @@  copy_file (int ifd, const char *datafile, int pad)
 	(void) close (dfd);
 }
 
-void
-usage ()
+static void usage(void)
 {
 	fprintf (stderr, "Usage: %s -l image\n"
 			 "          -l ==> list image header information\n",