Patchwork [1/2] mtd: Make deregister_mtd_parser return void

login
register
mail settings
Submitter Axel Lin
Date Dec. 1, 2013, 10:59 a.m.
Message ID <1385895555.3994.4.camel@phoenix>
Download mbox | patch
Permalink /patch/295646/
State Accepted
Commit cf3b2b1e24998ba67ca6defa71899bee2432046f
Headers show

Comments

Axel Lin - Dec. 1, 2013, 10:59 a.m.
deregister_mtd_parser never fails, hence make it return void.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mtd/mtdpart.c          | 3 +--
 include/linux/mtd/partitions.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
Brian Norris - Dec. 9, 2013, 8 p.m.
On Sun, Dec 01, 2013 at 06:59:15PM +0800, Axel Lin wrote:
> deregister_mtd_parser never fails, hence make it return void.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Pushed both to l2-mtd.git.

Brian

Patch

diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 67a89bb..29ee91e 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -682,12 +682,11 @@  int register_mtd_parser(struct mtd_part_parser *p)
 }
 EXPORT_SYMBOL_GPL(register_mtd_parser);
 
-int deregister_mtd_parser(struct mtd_part_parser *p)
+void deregister_mtd_parser(struct mtd_part_parser *p)
 {
 	spin_lock(&part_parser_lock);
 	list_del(&p->list);
 	spin_unlock(&part_parser_lock);
-	return 0;
 }
 EXPORT_SYMBOL_GPL(deregister_mtd_parser);
 
diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
index 335ffca..d513ffb 100644
--- a/include/linux/mtd/partitions.h
+++ b/include/linux/mtd/partitions.h
@@ -77,7 +77,7 @@  struct mtd_part_parser {
 };
 
 extern int register_mtd_parser(struct mtd_part_parser *parser);
-extern int deregister_mtd_parser(struct mtd_part_parser *parser);
+extern void deregister_mtd_parser(struct mtd_part_parser *parser);
 
 int mtd_is_partition(const struct mtd_info *mtd);
 int mtd_add_partition(struct mtd_info *master, const char *name,