diff mbox

sctp: check the rto_min and rto_max

Message ID 5299BCB8.6070409@huawei.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

wangweidong Nov. 30, 2013, 10:23 a.m. UTC
rto_min should be smaller than rto_max while rto_max should be larger
than rto_min. so just add the check.

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
 net/sctp/sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Neil Horman Nov. 30, 2013, 2:17 p.m. UTC | #1
On Sat, Nov 30, 2013 at 06:23:52PM +0800, wangweidong wrote:
> rto_min should be smaller than rto_max while rto_max should be larger
> than rto_min. so just add the check.
> 
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
>  net/sctp/sysctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
> index 6b36561..7637e8e 100644
> --- a/net/sctp/sysctl.c
> +++ b/net/sctp/sysctl.c
> @@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec_minmax,
>  		.extra1         = &one,
> -		.extra2         = &timer_max
> +		.extra2         = &init_net.sctp.rto_max
>  	},
>  	{
>  		.procname	= "rto_max",
> @@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
>  		.maxlen		= sizeof(unsigned int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec_minmax,
> -		.extra1         = &one,
> +		.extra1         = &init_net.sctp.rto_min,
>  		.extra2         = &timer_max
>  	},
>  	{
> -- 
> 1.7.12
> 
> 
> 

Acked-by: Neil Horman <nhorman@tuxdriver.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Nov. 30, 2013, 9:08 p.m. UTC | #2
From: wangweidong <wangweidong1@huawei.com>
Date: Sat, 30 Nov 2013 18:23:52 +0800

> rto_min should be smaller than rto_max while rto_max should be larger
> than rto_min. so just add the check.
> 
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>

Please fix your submission process such that your real full name
appears in the "From: " field of your patch emails, instead of
just "wangweidong", which is your username not your real full
name.

I'm not applying your patches until you correct this and submit
the patch properly, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
wangweidong Dec. 2, 2013, 1:33 a.m. UTC | #3
On 2013/12/1 5:08, David Miller wrote:
> From: wangweidong <wangweidong1@huawei.com>
> Date: Sat, 30 Nov 2013 18:23:52 +0800
> 
>> rto_min should be smaller than rto_max while rto_max should be larger
>> than rto_min. so just add the check.
>>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> 
> Please fix your submission process such that your real full name
> appears in the "From: " field of your patch emails, instead of
> just "wangweidong", which is your username not your real full
> name.
> 
> I'm not applying your patches until you correct this and submit
> the patch properly, thanks.
> 

Ok, I will fix it in v2.
Thanks.

> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index 6b36561..7637e8e 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -104,7 +104,7 @@  static struct ctl_table sctp_net_table[] = {
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
 		.extra1         = &one,
-		.extra2         = &timer_max
+		.extra2         = &init_net.sctp.rto_max
 	},
 	{
 		.procname	= "rto_max",
@@ -112,7 +112,7 @@  static struct ctl_table sctp_net_table[] = {
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1         = &one,
+		.extra1         = &init_net.sctp.rto_min,
 		.extra2         = &timer_max
 	},
 	{