Patchwork [v5,2/2] PCI: designware: Remove redundant call to pci_write_config

login
register
mail settings
Submitter Bjørn Erik Nilsen
Date Nov. 29, 2013, 1:35 p.m.
Message ID <1385732125-28630-3-git-send-email-ben@datarespons.no>
Download mbox | patch
Permalink /patch/295336/
State Changes Requested
Headers show

Comments

Bjørn Erik Nilsen - Nov. 29, 2013, 1:35 p.m.
write_msi_msg() does exactly the same so there is no need
to explicitly call pci_write_config and do the same twice.

Signed-off-by: Bjørn Erik Nilsen <ben@datarespons.no>
---
 drivers/pci/host/pcie-designware.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 61345a1..212b8b6 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -345,10 +345,10 @@  static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev,
 	if (irq < 0)
 		return irq;
 
-	msg_ctr &= ~PCI_MSI_FLAGS_QSIZE;
-	msg_ctr |= msgvec << 4;
-	pci_write_config_word(pdev, desc->msi_attrib.pos + PCI_MSI_FLAGS,
-				msg_ctr);
+	/*
+	 * write_msi_msg() will update PCI_MSI_FLAGS so there is
+	 * no need to explicitly call pci_write_config.
+	 */
 	desc->msi_attrib.multiple = msgvec;
 
 	msg.address_lo = virt_to_phys((void *)pp->msi_data);