Patchwork [v2] mxc_nand: remove duplicated ecc_stats counting

login
register
mail settings
Submitter Michael Grzeschik
Date Nov. 29, 2013, 1:14 p.m.
Message ID <1385730869-2322-1-git-send-email-m.grzeschik@pengutronix.de>
Download mbox | patch
Permalink /patch/295310/
State Accepted
Headers show

Comments

Michael Grzeschik - Nov. 29, 2013, 1:14 p.m.
The ecc_stats.corrected count variable will already be incremented in
the above framework-layer just after this callback.

Cc: stable@vger.kernel.org
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 drivers/mtd/nand/mxc_nand.c | 1 -
 1 file changed, 1 deletion(-)
Brian Norris - Dec. 4, 2013, 9:20 p.m.
On Fri, Nov 29, 2013 at 02:14:29PM +0100, Michael Grzeschik wrote:
> The ecc_stats.corrected count variable will already be incremented in
> the above framework-layer just after this callback.
> 
> Cc: stable@vger.kernel.org

Added a 2.6.36+ note, just for reference.

> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Pushed to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 9dfdb06..a4bad11 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -677,7 +677,6 @@  static int mxc_nand_correct_data_v2_v3(struct mtd_info *mtd, u_char *dat,
 		ecc_stat >>= 4;
 	} while (--no_subpages);
 
-	mtd->ecc_stats.corrected += ret;
 	pr_debug("%d Symbol Correctable RS-ECC Error\n", ret);
 
 	return ret;