| Message ID | 1385706857-12809-3-git-send-email-yamada.m@jp.panasonic.com |
|---|---|
| State | Rejected |
| Delegated to: | Sonic Zhang |
| Headers | show |
Hi Yamada, The init.elf is used to debug u-boot boot process on Blackfin via JTAG. You can't load u-boot binary to memory via JTAG without run the init.elf in Blackfin L1 SRAM first. So, this can't be removed. Regards, Sonic >-----Original Message----- >From: Masahiro Yamada [mailto:yamada.m@jp.panasonic.com] >Sent: Friday, November 29, 2013 2:34 PM >To: u-boot@lists.denx.de >Cc: Masahiro Yamada; Zhang, Sonic >Subject: [PATCH 2/2] blackfin: Do not generate unused binary init.elf > >Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> >--- > >Hello Sonic > >This file too. >It looks like arch/blackfin/cpu/init.elf is not used. > >Please let me know if this file is necessary or not. > >Best Regards >Masahiro Yamada > > > Makefile | 1 - > arch/blackfin/cpu/.gitignore | 2 -- > arch/blackfin/cpu/Makefile | 6 ------ > arch/blackfin/cpu/init.lds.S | 25 ------------------------- > 4 files changed, 34 deletions(-) > delete mode 100644 arch/blackfin/cpu/.gitignore delete mode 100644 >arch/blackfin/cpu/init.lds.S > >diff --git a/Makefile b/Makefile >index bbb053f..b7df731 100644 >--- a/Makefile >+++ b/Makefile >@@ -794,7 +794,6 @@ clean: > $(obj)board/matrix_vision/*/bootscript.img \ > $(obj)board/voiceblue/eeprom \ > $(obj)u-boot.lds \ >- $(obj)arch/blackfin/cpu/init.{lds,elf} > @rm -f $(obj)include/bmp_logo.h > @rm -f $(obj)include/bmp_logo_data.h > @rm -f $(obj)lib/asm-offsets.s >diff --git a/arch/blackfin/cpu/.gitignore b/arch/blackfin/cpu/.gitignore deleted file mode >100644 index 3df1fa2..0000000 >--- a/arch/blackfin/cpu/.gitignore >+++ /dev/null >@@ -1,2 +0,0 @@ >-init.lds >-init.elf >diff --git a/arch/blackfin/cpu/Makefile b/arch/blackfin/cpu/Makefile index >a61594a..f574ccb 100644 >--- a/arch/blackfin/cpu/Makefile >+++ b/arch/blackfin/cpu/Makefile >@@ -9,7 +9,6 @@ > # Licensed under the GPL-2 or later. > # > >-extra-y := init.elf > extra-y += initcode.o > extra-y += start.o > obj-y := interrupt.o cache.o >@@ -34,8 +33,3 @@ ifneq >($(CONFIG_BFIN_BOOT_MODE),BFIN_BOOT_BYPASS) > exit 1 ; \ > fi > endif >- >-$(obj)init.lds: init.lds.S >- $(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P $^ -o $@ >-$(obj)init.elf: $(obj)init.lds $(obj)init.o $(obj)initcode.o >- $(LD) $(LDFLAGS) -T $^ -o $@ >diff --git a/arch/blackfin/cpu/init.lds.S b/arch/blackfin/cpu/init.lds.S deleted file mode >100644 index 602e7c8..0000000 >--- a/arch/blackfin/cpu/init.lds.S >+++ /dev/null >@@ -1,25 +0,0 @@ >-/* >- * linker script for simple init.elf >- * >- * Copyright (c) 2005-2011 Analog Device Inc. >- * >- * Licensed under the GPL-2 or later. >- */ >- >-#include <config.h> >-#include <asm/blackfin.h> >-#undef ALIGN >-#undef ENTRY >- >-OUTPUT_ARCH(bfin) >- >-MEMORY >-{ >- l1_code : ORIGIN = L1_INST_SRAM, LENGTH = L1_INST_SRAM_SIZE >-} >- >-ENTRY(_start) >-SECTIONS >-{ >- .text.l1 : { *(.text .text.*) } >l1_code >-} >-- >1.8.3.2 >
Hello Sonic
> The init.elf is used to debug u-boot boot process on Blackfin via JTAG. You can't load u-boot binary to memory via JTAG without run the init.elf in Blackfin L1 SRAM first. So, this can't be removed.
I understand. Thanks!
Please reject this patch.
How about the other one?
arch/blackfin/cpu/bootrom-asm-offsets.h
Best Regards
Masahiro Yamada
NAK Sonic Zhang On Fri, Nov 29, 2013 at 2:34 PM, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote: > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > --- > > Hello Sonic > > This file too. > It looks like arch/blackfin/cpu/init.elf is not used. > > Please let me know if this file is necessary or not. > > Best Regards > Masahiro Yamada > > > Makefile | 1 - > arch/blackfin/cpu/.gitignore | 2 -- > arch/blackfin/cpu/Makefile | 6 ------ > arch/blackfin/cpu/init.lds.S | 25 ------------------------- > 4 files changed, 34 deletions(-) > delete mode 100644 arch/blackfin/cpu/.gitignore > delete mode 100644 arch/blackfin/cpu/init.lds.S > > diff --git a/Makefile b/Makefile > index bbb053f..b7df731 100644 > --- a/Makefile > +++ b/Makefile > @@ -794,7 +794,6 @@ clean: > $(obj)board/matrix_vision/*/bootscript.img \ > $(obj)board/voiceblue/eeprom \ > $(obj)u-boot.lds \ > - $(obj)arch/blackfin/cpu/init.{lds,elf} > @rm -f $(obj)include/bmp_logo.h > @rm -f $(obj)include/bmp_logo_data.h > @rm -f $(obj)lib/asm-offsets.s > diff --git a/arch/blackfin/cpu/.gitignore b/arch/blackfin/cpu/.gitignore > deleted file mode 100644 > index 3df1fa2..0000000 > --- a/arch/blackfin/cpu/.gitignore > +++ /dev/null > @@ -1,2 +0,0 @@ > -init.lds > -init.elf > diff --git a/arch/blackfin/cpu/Makefile b/arch/blackfin/cpu/Makefile > index a61594a..f574ccb 100644 > --- a/arch/blackfin/cpu/Makefile > +++ b/arch/blackfin/cpu/Makefile > @@ -9,7 +9,6 @@ > # Licensed under the GPL-2 or later. > # > > -extra-y := init.elf > extra-y += initcode.o > extra-y += start.o > obj-y := interrupt.o cache.o > @@ -34,8 +33,3 @@ ifneq ($(CONFIG_BFIN_BOOT_MODE),BFIN_BOOT_BYPASS) > exit 1 ; \ > fi > endif > - > -$(obj)init.lds: init.lds.S > - $(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P $^ -o $@ > -$(obj)init.elf: $(obj)init.lds $(obj)init.o $(obj)initcode.o > - $(LD) $(LDFLAGS) -T $^ -o $@ > diff --git a/arch/blackfin/cpu/init.lds.S b/arch/blackfin/cpu/init.lds.S > deleted file mode 100644 > index 602e7c8..0000000 > --- a/arch/blackfin/cpu/init.lds.S > +++ /dev/null > @@ -1,25 +0,0 @@ > -/* > - * linker script for simple init.elf > - * > - * Copyright (c) 2005-2011 Analog Device Inc. > - * > - * Licensed under the GPL-2 or later. > - */ > - > -#include <config.h> > -#include <asm/blackfin.h> > -#undef ALIGN > -#undef ENTRY > - > -OUTPUT_ARCH(bfin) > - > -MEMORY > -{ > - l1_code : ORIGIN = L1_INST_SRAM, LENGTH = L1_INST_SRAM_SIZE > -} > - > -ENTRY(_start) > -SECTIONS > -{ > - .text.l1 : { *(.text .text.*) } >l1_code > -} > -- > 1.8.3.2 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/Makefile b/Makefile index bbb053f..b7df731 100644 --- a/Makefile +++ b/Makefile @@ -794,7 +794,6 @@ clean: $(obj)board/matrix_vision/*/bootscript.img \ $(obj)board/voiceblue/eeprom \ $(obj)u-boot.lds \ - $(obj)arch/blackfin/cpu/init.{lds,elf} @rm -f $(obj)include/bmp_logo.h @rm -f $(obj)include/bmp_logo_data.h @rm -f $(obj)lib/asm-offsets.s diff --git a/arch/blackfin/cpu/.gitignore b/arch/blackfin/cpu/.gitignore deleted file mode 100644 index 3df1fa2..0000000 --- a/arch/blackfin/cpu/.gitignore +++ /dev/null @@ -1,2 +0,0 @@ -init.lds -init.elf diff --git a/arch/blackfin/cpu/Makefile b/arch/blackfin/cpu/Makefile index a61594a..f574ccb 100644 --- a/arch/blackfin/cpu/Makefile +++ b/arch/blackfin/cpu/Makefile @@ -9,7 +9,6 @@ # Licensed under the GPL-2 or later. # -extra-y := init.elf extra-y += initcode.o extra-y += start.o obj-y := interrupt.o cache.o @@ -34,8 +33,3 @@ ifneq ($(CONFIG_BFIN_BOOT_MODE),BFIN_BOOT_BYPASS) exit 1 ; \ fi endif - -$(obj)init.lds: init.lds.S - $(CPP) $(CPPFLAGS) $(LDPPFLAGS) -ansi -D__ASSEMBLY__ -P $^ -o $@ -$(obj)init.elf: $(obj)init.lds $(obj)init.o $(obj)initcode.o - $(LD) $(LDFLAGS) -T $^ -o $@ diff --git a/arch/blackfin/cpu/init.lds.S b/arch/blackfin/cpu/init.lds.S deleted file mode 100644 index 602e7c8..0000000 --- a/arch/blackfin/cpu/init.lds.S +++ /dev/null @@ -1,25 +0,0 @@ -/* - * linker script for simple init.elf - * - * Copyright (c) 2005-2011 Analog Device Inc. - * - * Licensed under the GPL-2 or later. - */ - -#include <config.h> -#include <asm/blackfin.h> -#undef ALIGN -#undef ENTRY - -OUTPUT_ARCH(bfin) - -MEMORY -{ - l1_code : ORIGIN = L1_INST_SRAM, LENGTH = L1_INST_SRAM_SIZE -} - -ENTRY(_start) -SECTIONS -{ - .text.l1 : { *(.text .text.*) } >l1_code -}
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> --- Hello Sonic This file too. It looks like arch/blackfin/cpu/init.elf is not used. Please let me know if this file is necessary or not. Best Regards Masahiro Yamada Makefile | 1 - arch/blackfin/cpu/.gitignore | 2 -- arch/blackfin/cpu/Makefile | 6 ------ arch/blackfin/cpu/init.lds.S | 25 ------------------------- 4 files changed, 34 deletions(-) delete mode 100644 arch/blackfin/cpu/.gitignore delete mode 100644 arch/blackfin/cpu/init.lds.S