From patchwork Sun Jul 5 11:10:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 29507 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id ED9FEB707F for ; Tue, 7 Jul 2009 01:45:01 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MNqHN-0004Za-TU; Mon, 06 Jul 2009 15:38:53 +0000 Received: from sorrow.cyrius.com ([65.19.161.204]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MNqHF-0004YV-1c for linux-mtd@lists.infradead.org; Mon, 06 Jul 2009 15:38:51 +0000 Received: by sorrow.cyrius.com (Postfix, from userid 10) id 9F4DDD8D8; Mon, 6 Jul 2009 15:38:41 +0000 (UTC) Received: by deprecation.cyrius.com (Postfix, from userid 1000) id 778141602AE; Mon, 6 Jul 2009 17:38:31 +0200 (CEST) Resent-From: tbm@cyrius.com Resent-Date: Mon, 6 Jul 2009 17:38:31 +0200 Resent-Message-ID: <20090706153831.GC2467@deprecation.cyrius.com> Resent-To: linux-mtd@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on deprecation.cyrius.com X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham version=3.2.5 X-Original-To: tbm@cyrius.com Received: by deprecation.cyrius.com (Postfix, from userid 10) id 80DEC151166; Sun, 5 Jul 2009 13:44:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by sorrow.cyrius.com (Postfix) with ESMTP id 0AA24D8D1 for ; Sun, 5 Jul 2009 11:18:20 +0000 (UTC) Received: from sorrow.cyrius.com ([127.0.0.1]) by localhost (sorrow.cyrius.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LofeS-uWZi1Q for ; Sun, 5 Jul 2009 11:18:15 +0000 (UTC) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by sorrow.cyrius.com (Postfix) with ESMTP id BB224D8C4 for ; Sun, 5 Jul 2009 11:18:14 +0000 (UTC) Received: by ey-out-2122.google.com with SMTP id 9so743299eyd.11 for ; Sun, 05 Jul 2009 04:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=EhmqvfeDlpNm20PykHxQTyCJgtpUG67yJm0GNCCUE7o=; b=tMX7BzlpXMrMZv3mT5AeWtbZd5UxBvOoAHSRooqZSgL83VX1xMTkRLhoCZwcg+K9ag 6LSXtdNlbPmcJt6xwHthjAYjCfesaq8NF9aeZpOUKlLSZOzHC3lfs9y07JLg6uNoFJD2 LraaBgfaSoYz6uGcakMs1jo931xuLhV6ssQu0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=R3i4ZjmU3eYgkuTBbjm0tTiOuDby66LObxSwDNaVjrFRKxf1PjPYbVM1B//Y8Dz/LE jfb+uQ4QoCltnGUsNUDe3NdB6jrFeAZCq4gZPO62Wjrpa7GjGUidQEWAgwtoYUsqpGLi hfm5nm6J7+ivOWDsAmVS3oULrq0U/cMkCWZ8M= Received: by 10.210.81.9 with SMTP id e9mr3393726ebb.68.1246792211285; Sun, 05 Jul 2009 04:10:11 -0700 (PDT) Received: from lenovo.mimichou.home (home.mimichou.net [82.67.132.19]) by mx.google.com with ESMTPS id 28sm8287505eye.16.2009.07.05.04.10.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 05 Jul 2009 04:10:07 -0700 (PDT) From: Florian Fainelli To: Martin Michlmayr Subject: Re: mtd related Cobalt build failure with current git Date: Sun, 5 Jul 2009 13:10:01 +0200 User-Agent: KMail/1.9.9 References: <20090704213741.GA6438@deprecation.cyrius.com> In-Reply-To: <20090704213741.GA6438@deprecation.cyrius.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200907051310.02673.florian@openwrt.org> X-Spam-Score: 0.0 (/) Cc: linux-mips@linux-mips.org, dwmw2@infradead.org, Yoichi Yuasa X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi Martin, Le Saturday 04 July 2009 23:37:41 Martin Michlmayr, vous avez écrit : > I get the following Cobalt build failure with current git: > > CC arch/mips/cobalt/mtd.o > cc1: warnings being treated as errors > In file included from arch/mips/cobalt/mtd.c:22: > include/linux/mtd/partitions.h:50: warning: ‘struct mtd_info’ declared > inside parameter list include/linux/mtd/partitions.h:50: warning: its scope > is only this definition or declaration, which is probably not what you want > include/linux/mtd/partitions.h:51: warning: ‘struct mtd_info’ declared > inside parameter list include/linux/mtd/partitions.h:61: warning: ‘struct > mtd_info’ declared inside parameter list include/linux/mtd/partitions.h:67: > warning: ‘struct mtd_info’ declared inside parameter list make[1]: *** > [arch/mips/cobalt/mtd.o] Error 1 > make: *** [arch/mips/cobalt] Error 2 > > Does anyone know if there's a fix for this already? I also had that problem and did the following fix, which still applies to the mtd-2.6 tree, master branch. --- From: Florian Fainelli Subject: [PATCH] Fix arch/mips/cobalt/mtd.c build failure This patch fixes a warning in include/linux/mtd/partitions which results in the following build failure on MIPS: CC arch/mips/cobalt/mtd.o cc1: warnings being treated as errors In file included from arch/mips/cobalt/mtd.c:22: include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list make[1]: *** [arch/mips/cobalt/mtd.o] Error 1 make: *** [arch/mips/cobalt] Error 2 Reported-by: Martin Michlmayr Signed-off-by: Florian Fainelli --- diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h index af6dcb9..c8eaf44 100644 --- a/include/linux/mtd/partitions.h +++ b/include/linux/mtd/partitions.h @@ -10,7 +10,7 @@ #define MTD_PARTITIONS_H #include - +#include /* * Partition definition structure: