| Message ID | 1385654237-36389-3-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Vicente Olivert Riera, On Thu, 28 Nov 2013 15:57:16 +0000, Vicente Olivert Riera wrote: > Is the same problem as Qt4 QtScript, it doesn't build because it uses > JavaScriptCore, so we re-use the existing > BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which > platforms are supported by JavaScriptCore. > > This is a quick fix. A proposed fix to add support for MIPS64 has > already been sent to Qt: > > https://bugreports.qt-project.org/browse/QTBUG-35191 > > Fixes: > > http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/ > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > package/qt5/qt5script/Config.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/package/qt5/qt5script/Config.in > b/package/qt5/qt5script/Config.in index 3c5d60c..8f03e75 100644 > --- a/package/qt5/qt5script/Config.in > +++ b/package/qt5/qt5script/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_QT5SCRIPT > bool "qt5script" > + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT No. Qt5 stuff should not use a symbol that is specific to Qt4, as the set of architectures supported by Qt4 may be different than the set of architectures supported by Qt5. Also, your patch series looks weird: it starts with PATCHv3 1/2 to fix qt4, then PATCH v3 2/2 to fix grantle, and then in the same thread (so same patch series), it continues with PATCH 1/2 and PATCH 2/2 for qt5. Either make separate patch series, or better, just one patch series with all patches (so PATCHv3 1/4 to PATCHv3 4/4). Thanks! Thomas
Dear Vicente Olivert Riera, On Thu, 28 Nov 2013 15:57:16 +0000, Vicente Olivert Riera wrote: > Is the same problem as Qt4 QtScript, it doesn't build because it uses > JavaScriptCore, so we re-use the existing > BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which > platforms are supported by JavaScriptCore. > > This is a quick fix. A proposed fix to add support for MIPS64 has > already been sent to Qt: > > https://bugreports.qt-project.org/browse/QTBUG-35191 > > Fixes: > > http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/ What is the status of this patch, and the "[PATCH 2/2] qt5quick1: Disable on non-supported platforms" patch that you sent? Are they still needed? If so, then it should use a QT5 specific Kconfig symbol. Let me know what to do with these patches, so that I can updated their patchwork status. Thanks! Thomas
diff --git a/package/qt5/qt5script/Config.in b/package/qt5/qt5script/Config.in index 3c5d60c..8f03e75 100644 --- a/package/qt5/qt5script/Config.in +++ b/package/qt5/qt5script/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_QT5SCRIPT bool "qt5script" + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT select BR2_PACKAGE_QT5BASE help Qt is a cross-platform application and UI framework for
Is the same problem as Qt4 QtScript, it doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore. This is a quick fix. A proposed fix to add support for MIPS64 has already been sent to Qt: https://bugreports.qt-project.org/browse/QTBUG-35191 Fixes: http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/ Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/qt5/qt5script/Config.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)