diff mbox

[iptables] iptables/Makefile.am: fix more static linking issues

Message ID 1385555493-25856-1-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias Nov. 27, 2013, 12:31 p.m. UTC
On uClibc-based targets dlfcn.h isn't available when built for
static-only targets.
Add up -DNO_SHARED_LIBS when building static so as to guard off the
include.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 iptables/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Westphal Nov. 27, 2013, 1:10 p.m. UTC | #1
Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:
> On uClibc-based targets dlfcn.h isn't available when built for
> static-only targets.
> Add up -DNO_SHARED_LIBS when building static so as to guard off the
> include.

Hmmm, it seems simpler to just kill #include <dlfcn.h>
from ip(6)tables-save.c -- I don't see why it would be needed there.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gustavo Zacarias Nov. 27, 2013, 1:20 p.m. UTC | #2
On 11/27/2013 10:10 AM, Florian Westphal wrote:

> Hmmm, it seems simpler to just kill #include <dlfcn.h>
> from ip(6)tables-save.c -- I don't see why it would be needed there.

Fair enough, i'll send a revised patch.
Regards.


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/iptables/Makefile.am b/iptables/Makefile.am
index a4246eb..1122d72 100644
--- a/iptables/Makefile.am
+++ b/iptables/Makefile.am
@@ -7,7 +7,7 @@  xtables_multi_SOURCES  = xtables-multi.c iptables-xml.c
 xtables_multi_CFLAGS   = ${AM_CFLAGS}
 xtables_multi_LDADD    = ../extensions/libext.a
 if ENABLE_STATIC
-xtables_multi_CFLAGS  += -DALL_INCLUSIVE
+xtables_multi_CFLAGS  += -DALL_INCLUSIVE -DNO_SHARED_LIBS
 endif
 if ENABLE_IPV4
 xtables_multi_SOURCES += iptables-save.c iptables-restore.c \