| Message ID | 1385539172-4744-1-git-send-email-ivecera@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> -----Original Message----- > From: Ivan Vecera [mailto:ivecera@redhat.com] > > The recent be2net commit 6384a4d (adds a support for busy polling) > introduces a regression that results in kernel crash. It incorrectly > modified be_close() so napi_disable() is called only for the first queue. > This breaks a correct pairing of napi_enable/_disable for the rest > of event queues and causes a crash in subsequent be_open() call. > > v2: Applied suggestions from Sathya > > Fixes: 6384a4d ("be2net: add support for ndo_busy_poll") > Cc: Sathya Perla <sathya.perla@emulex.com> > Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com> > Cc: Ajit Khaparde <ajit.khaparde@emulex.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Acked-by: Sathya Perla <sathya.perla@emulex.com> > --- > drivers/net/ethernet/emulex/benet/be_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c > b/drivers/net/ethernet/emulex/benet/be_main.c > index 78a0e85..fee64bf 100644 > --- a/drivers/net/ethernet/emulex/benet/be_main.c > +++ b/drivers/net/ethernet/emulex/benet/be_main.c > @@ -2658,8 +2658,8 @@ static int be_close(struct net_device *netdev) > > be_roce_dev_close(adapter); > > - for_all_evt_queues(adapter, eqo, i) { > - if (adapter->flags & BE_FLAGS_NAPI_ENABLED) { > + if (adapter->flags & BE_FLAGS_NAPI_ENABLED) { > + for_all_evt_queues(adapter, eqo, i) { > napi_disable(&eqo->napi); > be_disable_busy_poll(eqo); > } > -- > 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ivan Vecera <ivecera@redhat.com> Date: Wed, 27 Nov 2013 08:59:32 +0100 > The recent be2net commit 6384a4d (adds a support for busy polling) > introduces a regression that results in kernel crash. It incorrectly > modified be_close() so napi_disable() is called only for the first queue. > This breaks a correct pairing of napi_enable/_disable for the rest > of event queues and causes a crash in subsequent be_open() call. > > v2: Applied suggestions from Sathya > > Fixes: 6384a4d ("be2net: add support for ndo_busy_poll") > Cc: Sathya Perla <sathya.perla@emulex.com> > Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com> > Cc: Ajit Khaparde <ajit.khaparde@emulex.com> > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 78a0e85..fee64bf 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -2658,8 +2658,8 @@ static int be_close(struct net_device *netdev) be_roce_dev_close(adapter); - for_all_evt_queues(adapter, eqo, i) { - if (adapter->flags & BE_FLAGS_NAPI_ENABLED) { + if (adapter->flags & BE_FLAGS_NAPI_ENABLED) { + for_all_evt_queues(adapter, eqo, i) { napi_disable(&eqo->napi); be_disable_busy_poll(eqo); }
The recent be2net commit 6384a4d (adds a support for busy polling) introduces a regression that results in kernel crash. It incorrectly modified be_close() so napi_disable() is called only for the first queue. This breaks a correct pairing of napi_enable/_disable for the rest of event queues and causes a crash in subsequent be_open() call. v2: Applied suggestions from Sathya Fixes: 6384a4d ("be2net: add support for ndo_busy_poll") Cc: Sathya Perla <sathya.perla@emulex.com> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com> Cc: Ajit Khaparde <ajit.khaparde@emulex.com> Signed-off-by: Ivan Vecera <ivecera@redhat.com> --- drivers/net/ethernet/emulex/benet/be_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)