| Message ID | 1385488975-27694-1-git-send-email-jgunthorpe@obsidianresearch.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Nov 26, 2013 at 11:02:52AM -0700, Jason Gunthorpe wrote: > There are no writable bits in the secondary status register, only > write 1 to clear bits. The driver never sets any of the write 1 to > clear bits so the status register should always be 0, just remove > the set from the write path. > > Someday the write 1 to clear bits should be copied/cleared directly > from registers in the HW. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > --- > drivers/pci/host/pci-mvebu.c | 1 - > 1 file changed, 1 deletion(-) Whole series Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 26, 2013 at 01:23:28PM -0500, Jason Cooper wrote: > On Tue, Nov 26, 2013 at 11:02:52AM -0700, Jason Gunthorpe wrote: > > There are no writable bits in the secondary status register, only > > write 1 to clear bits. The driver never sets any of the write 1 to > > clear bits so the status register should always be 0, just remove > > the set from the write path. > > > > Someday the write 1 to clear bits should be copied/cleared directly > > from registers in the HW. > > > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > --- > > drivers/pci/host/pci-mvebu.c | 1 - > > 1 file changed, 1 deletion(-) > > Whole series > > Acked-by: Jason Cooper <jason@lakedaemon.net> Thanks, I applied the Interrupt Line/Pin change to for-linus for v3.13, and the others to pci/host-mvebu for v3.14. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index c269e43..6f5a20f 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -500,7 +500,6 @@ static int mvebu_sw_pci_bridge_write(struct mvebu_pcie_port *port, */ bridge->iobase = (value & 0xff) | PCI_IO_RANGE_TYPE_32; bridge->iolimit = ((value >> 8) & 0xff) | PCI_IO_RANGE_TYPE_32; - bridge->secondary_status = value >> 16; mvebu_pcie_handle_iobase_change(port); break;
There are no writable bits in the secondary status register, only write 1 to clear bits. The driver never sets any of the write 1 to clear bits so the status register should always be 0, just remove the set from the write path. Someday the write 1 to clear bits should be copied/cleared directly from registers in the HW. Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> --- drivers/pci/host/pci-mvebu.c | 1 - 1 file changed, 1 deletion(-) Thomas: This was the last patch in my set that you haven't reviewed. Thanks