| Message ID | 1385451313-1875-12-git-send-email-sourav.poddar@ti.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Nov 26, 2013 at 01:05:07PM +0530, Sourav Poddar wrote: > Set mmap flag to true to indicate that the qspi controller > supports memory mapped operations. Please combine some of these patches - adding the mmap support and then separately adding this flag isn't really helping bisection, just have one patch enabling support for mmap in the driver. Similarly adding internal functions to the driver with no users and then separately adding the users isn't really adding much.
On Tuesday 26 November 2013 06:40 PM, Mark Brown wrote: > On Tue, Nov 26, 2013 at 01:05:07PM +0530, Sourav Poddar wrote: >> Set mmap flag to true to indicate that the qspi controller >> supports memory mapped operations. > Please combine some of these patches - adding the mmap support and then > separately adding this flag isn't really helping bisection, just have > one patch enabling support for mmap in the driver. Similarly adding > internal functions to the driver with no users and then separately > adding the users isn't really adding much. Sure, I will do that in my next version.
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c index 10bcb37..d21d40d 100644 --- a/drivers/spi/spi-ti-qspi.c +++ b/drivers/spi/spi-ti-qspi.c @@ -532,6 +532,7 @@ static int ti_qspi_probe(struct platform_device *pdev) master->configure_from_slave = ti_qspi_configure_from_slave; master->get_buf = ti_qspi_get_mem_buf; master->put_buf = ti_qspi_put_mem_buf; + master->mmap = true; if (!of_property_read_u32(np, "num-cs", &num_cs)) master->num_chipselect = num_cs;
Set mmap flag to true to indicate that the qspi controller supports memory mapped operations. Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> --- drivers/spi/spi-ti-qspi.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)