| Message ID | alpine.DEB.2.02.1311252150050.22983@tomh.mtv.corp.google.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 25 Nov 2013, Tom Herbert wrote: > Drivers should call skb_get_rxhash to set the rxhash and its type in an skbuff. ^^^ It should be skb_set_rxhash right? I would like to have 'git log' show correct information. Otherwise this patch looks fine for me. Acked-by: Govindarajulu Varadarajan <govindarajulu90@gmail.com> > > Signed-off-by: Tom Herbert <therbert@google.com> > --- > drivers/net/ethernet/cisco/enic/enic_main.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c > index ff78dfa..ea30551 100644 > --- a/drivers/net/ethernet/cisco/enic/enic_main.c > +++ b/drivers/net/ethernet/cisco/enic/enic_main.c > @@ -1036,11 +1036,12 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq, > skb->protocol = eth_type_trans(skb, netdev); > skb_record_rx_queue(skb, q_number); > if (netdev->features & NETIF_F_RXHASH) { > - skb->rxhash = rss_hash; > - if (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX | > - NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 | > - NIC_CFG_RSS_HASH_TYPE_TCP_IPV4)) > - skb->l4_rxhash = true; > + skb_set_rxhash(skb, rss_hash, > + (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX | > + NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 | > + NIC_CFG_RSS_HASH_TYPE_TCP_IPV4)) ? > + RXHASH_TYPE_L4 : RXHASH_TYPE_L3); > + > } > > if ((netdev->features & NETIF_F_RXCSUM) && !csum_not_calc) { > -- > 1.8.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index ff78dfa..ea30551 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -1036,11 +1036,12 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq, skb->protocol = eth_type_trans(skb, netdev); skb_record_rx_queue(skb, q_number); if (netdev->features & NETIF_F_RXHASH) { - skb->rxhash = rss_hash; - if (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX | - NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 | - NIC_CFG_RSS_HASH_TYPE_TCP_IPV4)) - skb->l4_rxhash = true; + skb_set_rxhash(skb, rss_hash, + (rss_type & (NIC_CFG_RSS_HASH_TYPE_TCP_IPV6_EX | + NIC_CFG_RSS_HASH_TYPE_TCP_IPV6 | + NIC_CFG_RSS_HASH_TYPE_TCP_IPV4)) ? + RXHASH_TYPE_L4 : RXHASH_TYPE_L3); + } if ((netdev->features & NETIF_F_RXCSUM) && !csum_not_calc) {
Drivers should call skb_get_rxhash to set the rxhash and its type in an skbuff. Signed-off-by: Tom Herbert <therbert@google.com> --- drivers/net/ethernet/cisco/enic/enic_main.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)