| Message ID | 07bbc1df201bb49344b03161ec4f8867a18a0b78.1385390332.git.kiho@prevas.dk |
|---|---|
| State | Changes Requested |
| Delegated to: | Esben Haabendal |
| Headers | show |
<kim.hansen@prevas.dk> writes: > From: Kim Højgaard-Hansen <kiho@prevas.dk> > > --- > setup/centos_5 | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 setup/centos_5 > > diff --git a/setup/centos_5 b/setup/centos_5 > new file mode 100644 > index 0000000..e6ac2b2 > --- /dev/null > +++ b/setup/centos_5 > @@ -0,0 +1,2 @@ > +# CentOS 5.x > +# Not supported - The software available is too old, e.g. Python 2.4 > \ No newline at end of file As mentioned in commit d1e2f5d90b4359c044009a5db006754b77b09374: "Support empty (as in, only first description line) to mark known unsupported host distributions" the setup/centos_5 file should be truly empty for it to be marked as unsupported. /Esben
On 28/11/13 10:16, Esben Haabendal wrote: > <kim.hansen@prevas.dk> writes: > >> From: Kim Højgaard-Hansen <kiho@prevas.dk> >> >> --- >> setup/centos_5 | 2 ++ >> 1 file changed, 2 insertions(+) >> create mode 100644 setup/centos_5 >> >> diff --git a/setup/centos_5 b/setup/centos_5 >> new file mode 100644 >> index 0000000..e6ac2b2 >> --- /dev/null >> +++ b/setup/centos_5 >> @@ -0,0 +1,2 @@ >> +# CentOS 5.x >> +# Not supported - The software available is too old, e.g. Python 2.4 >> \ No newline at end of file > As mentioned in commit d1e2f5d90b4359c044009a5db006754b77b09374: > > "Support empty (as in, only first description line) to mark known > unsupported host distributions" > > the setup/centos_5 file should be truly empty for it to be marked as > unsupported. > > /Esben I thought it was nicer to explain why it is not supported, but feel free to override it /Kim
Kim Højgaard-Hansen <kiho@prevas.dk> writes: > On 28/11/13 10:16, Esben Haabendal wrote: >> <kim.hansen@prevas.dk> writes: >> >>> From: Kim Højgaard-Hansen <kiho@prevas.dk> >>> >>> --- >>> setup/centos_5 | 2 ++ >>> 1 file changed, 2 insertions(+) >>> create mode 100644 setup/centos_5 >>> >>> diff --git a/setup/centos_5 b/setup/centos_5 >>> new file mode 100644 >>> index 0000000..e6ac2b2 >>> --- /dev/null >>> +++ b/setup/centos_5 >>> @@ -0,0 +1,2 @@ >>> +# CentOS 5.x >>> +# Not supported - The software available is too old, e.g. Python 2.4 >>> \ No newline at end of file >> As mentioned in commit d1e2f5d90b4359c044009a5db006754b77b09374: >> >> "Support empty (as in, only first description line) to mark known >> unsupported host distributions" >> >> the setup/centos_5 file should be truly empty for it to be marked as >> unsupported. >> >> /Esben > I thought it was nicer to explain why it is not supported, but feel free to > override it Yes, I see that. But it is much simpler to check for empty files, than needing to parse them to find out this information. We could put the explanation in the commit message. Alternatively, the setup command should be extended to check for setup files that contains only comment and blank lines, and report these as unsupported. /Esben
diff --git a/setup/centos_5 b/setup/centos_5 new file mode 100644 index 0000000..e6ac2b2 --- /dev/null +++ b/setup/centos_5 @@ -0,0 +1,2 @@ +# CentOS 5.x +# Not supported - The software available is too old, e.g. Python 2.4
From: Kim Højgaard-Hansen <kiho@prevas.dk> --- setup/centos_5 | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 setup/centos_5 \ No newline at end of file