From patchwork Thu Jul 2 07:14:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sreenivasa Honnur X-Patchwork-Id: 29392 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 5106AB70F6 for ; Thu, 2 Jul 2009 17:26:52 +1000 (EST) Received: by ozlabs.org (Postfix) id 40AEADDDB6; Thu, 2 Jul 2009 17:26:52 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B4287DDDA1 for ; Thu, 2 Jul 2009 17:26:51 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbZGBH0l (ORCPT ); Thu, 2 Jul 2009 03:26:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752608AbZGBH0k (ORCPT ); Thu, 2 Jul 2009 03:26:40 -0400 Received: from barracuda.s2io.com ([72.1.205.138]:37772 "EHLO barracuda.s2io.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbZGBH0k (ORCPT ); Thu, 2 Jul 2009 03:26:40 -0400 X-ASG-Debug-ID: 1246518844-17a300810000-gSecQ8 X-Barracuda-URL: http://72.1.205.138:8000/cgi-bin/mark.cgi Received: from guinness.s2io.com (localhost [127.0.0.1]) by barracuda.s2io.com (Spam Firewall) with ESMTP id 81844202FAFA; Thu, 2 Jul 2009 03:14:04 -0400 (EDT) Received: from guinness.s2io.com (142-46-210.147.tel-ott.com [142.46.210.147]) by barracuda.s2io.com with ESMTP id tgVakPfO1TGZYnvE; Thu, 02 Jul 2009 03:14:04 -0400 (EDT) X-Barracuda-Envelope-From: Sreenivasa.Honnur@neterion.com X-ASG-Whitelist: Client Received: from guinness.s2io.com (localhost [127.0.0.1]) by guinness.s2io.com (8.12.6/8.12.6) with ESMTP id n627E3md013989; Thu, 2 Jul 2009 03:14:03 -0400 (EDT) Received: from localhost (shonnur@localhost) by guinness.s2io.com (8.12.6/8.12.6/Submit) with ESMTP id n627E3Dt013986; Thu, 2 Jul 2009 03:14:03 -0400 (EDT) Date: Thu, 2 Jul 2009 03:14:03 -0400 (EDT) From: Sreenivasa Honnur To: davem@davemloft.net cc: netdev@vger.kernel.org, support@neterion.com X-ASG-Orig-Subj: [net-next-2.6 PATCH 3/9] vxge: check for card status before continuing in device close Subject: [net-next-2.6 PATCH 3/9] vxge: check for card status before continuing in device close Message-ID: MIME-Version: 1.0 X-Barracuda-Connect: 142-46-210.147.tel-ott.com[142.46.210.147] X-Barracuda-Start-Time: 1246518844 X-Barracuda-Virus-Scanned: by Barracuda Spam Firewall at s2io.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org - Fixed the crash in rmmod after vpath open failed when trying to change mtu. We should check for card status before continuing in device close. Signed-off-by: Sreenivasa Honnur Signed-off-by: Ramkrishna Vepa --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -urpN patch_2/drivers/net/vxge/vxge-main.c patch_3/drivers/net/vxge/vxge-main.c --- patch_2/drivers/net/vxge/vxge-main.c 2009-06-21 23:43:43.000000000 -0700 +++ patch_3/drivers/net/vxge/vxge-main.c 2009-06-21 23:50:01.000000000 -0700 @@ -2890,6 +2890,9 @@ int do_vxge_close(struct net_device *dev vdev = (struct vxgedev *)netdev_priv(dev); hldev = (struct __vxge_hw_device *) pci_get_drvdata(vdev->pdev); + if (unlikely(!is_vxge_card_up(vdev))) + return 0; + /* If vxge_handle_crit_err task is executing, * wait till it completes. */ while (test_and_set_bit(__VXGE_STATE_RESET_CARD, &vdev->state))