Patchwork [net-next-2.6,7/9] vxge: Disable fcs stripping.

login
register
mail settings
Submitter Sreenivasa Honnur
Date July 2, 2009, 7:17 a.m.
Message ID <Pine.GSO.4.10.10907020316390.13763-100000@guinness>
Download mbox | patch
Permalink /patch/29389/
State Accepted
Delegated to: David Miller
Headers show

Comments

Sreenivasa Honnur - July 2, 2009, 7:17 a.m.
- Disable fcs stripping. The minimum frame size that can be received by the
hardware is 57 Bytes. A 64 Byte Ethernet frame with the vlan tag and fcs
stripped will result in a 56 Byte frame which will lock up the receive 
engine. The work around is to disable fcs stripping in the hardware which 
is done with a firmware upgrade. The fixes are -
1. Ensure that the correct firmware version is used.
2. Decrement the indicated packet length of the receive packet by 4 bytes
(FCS length).

Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -pNur patch-net-next-2.6/drivers/net/vxge/vxge-main.c patch-7-net-next-2.6/drivers/net/vxge/vxge-main.c
--- patch-net-next-2.6/drivers/net/vxge/vxge-main.c	2009-06-30 14:00:28.000000000 -0700
+++ patch-7-net-next-2.6/drivers/net/vxge/vxge-main.c	2009-06-30 17:18:17.000000000 -0700
@@ -454,6 +454,8 @@  vxge_rx_1b_compl(struct __vxge_hw_ring *
 		vxge_hw_ring_rxd_1b_get(ringh, dtr, &dma_sizes);
 		pkt_length = dma_sizes;
 
+		pkt_length -= ETH_FCS_LEN;
+
 		vxge_debug_rx(VXGE_TRACE,
 			"%s: %s:%d  Packet Length = %d",
 			ring->ndev->name, __func__, __LINE__, pkt_length);
@@ -4163,11 +4165,11 @@  vxge_probe(struct pci_dev *pdev, const s
 	}
 
 	if (ll_config.device_hw_info.fw_version.major !=
-		VXGE_DRIVER_VERSION_MAJOR) {
+		VXGE_DRIVER_FW_VERSION_MAJOR) {
 		vxge_debug_init(VXGE_ERR,
-			"FW Ver.(maj): %d not driver's expected version: %d",
-			ll_config.device_hw_info.fw_version.major,
-			VXGE_DRIVER_VERSION_MAJOR);
+			"%s: Incorrect firmware version."
+			"Please upgrade the firmware to version 1.x.x",
+			VXGE_DRIVER_NAME);
 		ret = -EINVAL;
 		goto _exit3;
 	}
diff -pNur patch-net-next-2.6/drivers/net/vxge/vxge-main.h patch-7-net-next-2.6/drivers/net/vxge/vxge-main.h
--- patch-net-next-2.6/drivers/net/vxge/vxge-main.h	2009-06-30 14:00:28.000000000 -0700
+++ patch-7-net-next-2.6/drivers/net/vxge/vxge-main.h	2009-06-30 15:28:04.000000000 -0700
@@ -21,7 +21,7 @@ 
 
 #define VXGE_DRIVER_NAME		"vxge"
 #define VXGE_DRIVER_VENDOR		"Neterion, Inc"
-#define VXGE_DRIVER_VERSION_MAJOR 0
+#define VXGE_DRIVER_FW_VERSION_MAJOR	1
 
 #define DRV_VERSION	VXGE_VERSION_MAJOR"."VXGE_VERSION_MINOR"."\
 	VXGE_VERSION_FIX"."VXGE_VERSION_BUILD"-"\