Message ID | 1385372437-20958-1-git-send-email-ian.campbell@citrix.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Benjamin Herrenschmidt |
Headers | show |
On Mon, Nov 25, 2013 at 4:40 AM, Ian Campbell <ian.campbell@citrix.com> wrote: > Currently I see: > DTC arch/powerpc/boot/kilauea.dtb > Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C10000000 has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1) > > It appears that unlike the other platforms handled by 3fb7933850fa > "powerpc/4xx: Adding PCIe MSI support" this platform does not use address-cells=2. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > Acked-by: Josh Boyer <jwboyer@gmail.com> > Cc: Rupjyoti Sarmah <rsarmah@apm.com> > Cc: Tirumala R Marri <tmarri@apm.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND...) > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > Resending, this hasn't been picked up since June > http://patchwork.ozlabs.org/patch/248234/ Ben, please pick this up. josh > --- > arch/powerpc/boot/dts/kilauea.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts > index 1613d6e..5ba7f01 100644 > --- a/arch/powerpc/boot/dts/kilauea.dts > +++ b/arch/powerpc/boot/dts/kilauea.dts > @@ -406,7 +406,7 @@ > > MSI: ppc4xx-msi@C10000000 { > compatible = "amcc,ppc4xx-msi", "ppc4xx-msi"; > - reg = < 0x0 0xEF620000 0x100>; > + reg = <0xEF620000 0x100>; > sdr-base = <0x4B0>; > msi-data = <0x00000000>; > msi-mask = <0x44440000>; > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts index 1613d6e..5ba7f01 100644 --- a/arch/powerpc/boot/dts/kilauea.dts +++ b/arch/powerpc/boot/dts/kilauea.dts @@ -406,7 +406,7 @@ MSI: ppc4xx-msi@C10000000 { compatible = "amcc,ppc4xx-msi", "ppc4xx-msi"; - reg = < 0x0 0xEF620000 0x100>; + reg = <0xEF620000 0x100>; sdr-base = <0x4B0>; msi-data = <0x00000000>; msi-mask = <0x44440000>;