Message ID | 20090701173925.GA22134@oksana.dev.rtsoft.ru (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Kumar Gala |
Headers | show |
On Wed, Jul 01, 2009 at 09:39:25PM +0400, Anton Vorontsov wrote: > Sometimes (e.g. when there are no UEMs attached to a board) > fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, > this is because get_phy_id() returns bogus 0x0000ffff values > (0xffffffff is expected), and therefore mdio bus probing fails with > the following message: > > fsl-pq_mdio: probe of e0082120.mdio failed with error -16 > > And obviously ethernet doesn't work after this. > > This patch solves the problem by adding tbi-phy node into mdio node, > so that we won't scan for spare addresses, we'll just use a fixed one. > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Kumar, I believe this patch is suitable for 2.6.31, no? Thanks, > --- > arch/powerpc/boot/dts/mpc8569mds.dts | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts > index 2577f37..baa4ac7 100644 > --- a/arch/powerpc/boot/dts/mpc8569mds.dts > +++ b/arch/powerpc/boot/dts/mpc8569mds.dts > @@ -502,6 +502,10 @@ > reg = <0x6>; > device_type = "ethernet-phy"; > }; > + tbi-phy@11 { > + reg = <0x11>; > + device_type = "tbi-phy"; > + }; > }; > mdio@3520 { > #address-cells = <1>; > -- > 1.6.3.3 > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Jul 1, 2009, at 12:39 PM, Anton Vorontsov wrote: > Sometimes (e.g. when there are no UEMs attached to a board) > fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, > this is because get_phy_id() returns bogus 0x0000ffff values > (0xffffffff is expected), and therefore mdio bus probing fails with > the following message: > > fsl-pq_mdio: probe of e0082120.mdio failed with error -16 > > And obviously ethernet doesn't work after this. > > This patch solves the problem by adding tbi-phy node into mdio node, > so that we won't scan for spare addresses, we'll just use a fixed one. > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- > arch/powerpc/boot/dts/mpc8569mds.dts | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) applied to merge - k
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts index 2577f37..baa4ac7 100644 --- a/arch/powerpc/boot/dts/mpc8569mds.dts +++ b/arch/powerpc/boot/dts/mpc8569mds.dts @@ -502,6 +502,10 @@ reg = <0x6>; device_type = "ethernet-phy"; }; + tbi-phy@11 { + reg = <0x11>; + device_type = "tbi-phy"; + }; }; mdio@3520 { #address-cells = <1>;
Sometimes (e.g. when there are no UEMs attached to a board) fsl_pq_mdio_find_free() fails to find a spare address for a TBI PHY, this is because get_phy_id() returns bogus 0x0000ffff values (0xffffffff is expected), and therefore mdio bus probing fails with the following message: fsl-pq_mdio: probe of e0082120.mdio failed with error -16 And obviously ethernet doesn't work after this. This patch solves the problem by adding tbi-phy node into mdio node, so that we won't scan for spare addresses, we'll just use a fixed one. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/boot/dts/mpc8569mds.dts | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)