Patchwork [2/2] mpg123: use code optimized for ARM NEON SIMD engine if available

login
register
mail settings
Submitter Sven Neumann
Date Nov. 22, 2013, 10 p.m.
Message ID <1385157653.14731.35.camel@bender>
Download mbox | patch
Permalink /patch/293605/
State Superseded
Headers show

Comments

Sven Neumann - Nov. 22, 2013, 10 p.m.
Signed-off-by: Sven Neumann <neumann@teufel.de>
---
 package/mpg123/mpg123.mk | 4 ++++
 1 file changed, 4 insertions(+)
Peter Korsgaard - Nov. 22, 2013, 10:37 p.m.
>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes:

 > Signed-off-by: Sven Neumann <neumann@teufel.de>
 > ---
 >  package/mpg123/mpg123.mk | 4 ++++
 >  1 file changed, 4 insertions(+)

 > diff --git a/package/mpg123/mpg123.mk b/package/mpg123/mpg123.mk
 > index 3db2843..0d5b1bc 100644
 > --- a/package/mpg123/mpg123.mk
 > +++ b/package/mpg123/mpg123.mk
 > @@ -15,8 +15,12 @@ MPG123_LICENSE_FILES = COPYING
 >  MPG123_CPU = $(if $(BR2_SOFT_FLOAT),generic_nofpu,generic_fpu)
 
 >  ifeq ($(BR2_arm),y)
 > +ifeq ($(BR2_ARM_FPU_NEON),y)
 > +MPG123_CPU = neon
 > +else

I don't know anything about the mpg123 code, but are you sure you need
ARM_FPU_NEON (E.G. do all fpu calculation using neon) and not just
BR2_ARM_CPU_HAS_NEON (E.G. cpu has neon support)?

Patch

diff --git a/package/mpg123/mpg123.mk b/package/mpg123/mpg123.mk
index 3db2843..0d5b1bc 100644
--- a/package/mpg123/mpg123.mk
+++ b/package/mpg123/mpg123.mk
@@ -15,8 +15,12 @@  MPG123_LICENSE_FILES = COPYING
 MPG123_CPU = $(if $(BR2_SOFT_FLOAT),generic_nofpu,generic_fpu)
 
 ifeq ($(BR2_arm),y)
+ifeq ($(BR2_ARM_FPU_NEON),y)
+MPG123_CPU = neon
+else
 MPG123_CPU = arm_nofpu
 endif
+endif
 
 ifeq ($(BR2_i386),y)
 MPG123_CPU = x86