| Message ID | 1385138401-26445-3-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Commit | 85ccc07b7427b54c20ed39264c9995279b0ff1d7 |
| Headers | show |
On 11/22/2013 07:58 PM, Peter Korsgaard wrote: > We have a problem here :/ > > The git tree tarball we used to download was also called jq-1.3.tar.gz, > so people who already downloaded it (and sources.buildroot.net) will NOT > redownload it, so the build will fail as there's no configure. As Danomi said it's a non-issue. I've got a patchset in the works for this kind of issues (together with the long overdue tarball hashes), however for personal reasons my free time is like 0 for at least a few days more. Regards.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > Ships configure thus fixing the breakage from the automake bump > to version 1.14 with AUTORECONF, with the added bonus of being faster. > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/jq/jq.mk | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > diff --git a/package/jq/jq.mk b/package/jq/jq.mk > index 8d4f24f..cc7c99e 100644 > --- a/package/jq/jq.mk > +++ b/package/jq/jq.mk > @@ -4,9 +4,8 @@ > # > ################################################################################ > -JQ_VERSION = jq-1.3 > -JQ_SITE = http://github.com/stedolan/jq/tarball/$(JQ_VERSION) > -JQ_AUTORECONF = YES > +JQ_VERSION = 1.3 > +JQ_SITE = http://stedolan.github.io/jq/download/source We have a problem here :/ The git tree tarball we used to download was also called jq-1.3.tar.gz, so people who already downloaded it (and sources.buildroot.net) will NOT redownload it, so the build will fail as there's no configure.
Peter, On Fri, Nov 22, 2013 at 5:58 PM, Peter Korsgaard <jacmet@uclibc.org> wrote: > > -JQ_VERSION = jq-1.3 > > -JQ_SITE = http://github.com/stedolan/jq/tarball/$(JQ_VERSION) > > -JQ_AUTORECONF = YES > > +JQ_VERSION = 1.3 > > +JQ_SITE = http://stedolan.github.io/jq/download/source > > We have a problem here :/ > > The git tree tarball we used to download was also called jq-1.3.tar.gz, > so people who already downloaded it (and sources.buildroot.net) will NOT > redownload it, so the build will fail as there's no configure. The jq.mk that was actually committed into buldroot's git repo downloads "jq-jq-1.3.tar.gz" (has an extra "-jq"). You probably have a "jq-1.3.tar.gz" because my initial patch submission acquired it from yet another URL on github. The v2 patch was changed to get the archive using the github example in the buildroot manual, resulting in the double-jq archive is used in the current jq.mk today. So the number of "dl" directories that have the old "jq-1.3.tar.gz" may be limited to just the few people who tried my initial v1 patch. Danomi -
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes: Hi, > The jq.mk that was actually committed into buldroot's git repo > downloads "jq-jq-1.3.tar.gz" (has an extra "-jq"). You probably have > a "jq-1.3.tar.gz" because my initial patch submission acquired it from > yet another URL on github. The v2 patch was changed to get the > archive using the github example in the buildroot manual, resulting in > the double-jq archive is used in the current jq.mk today. > So the number of "dl" directories that have the old "jq-1.3.tar.gz" > may be limited to just the few people who tried my initial v1 patch. Ahh yes, sorry about the noise then.
diff --git a/package/jq/jq.mk b/package/jq/jq.mk index 8d4f24f..cc7c99e 100644 --- a/package/jq/jq.mk +++ b/package/jq/jq.mk @@ -4,9 +4,8 @@ # ################################################################################ -JQ_VERSION = jq-1.3 -JQ_SITE = http://github.com/stedolan/jq/tarball/$(JQ_VERSION) -JQ_AUTORECONF = YES +JQ_VERSION = 1.3 +JQ_SITE = http://stedolan.github.io/jq/download/source JQ_DEPENDENCIES = host-flex host-bison JQ_LICENSE = MIT (code), CC-BY-3.0 (documentation) JQ_LICENSE_FILES = COPYING
Ships configure thus fixing the breakage from the automake bump to version 1.14 with AUTORECONF, with the added bonus of being faster. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/jq/jq.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)