diff mbox

[1/2] pcre: add options to enable UTF and UCP support

Message ID 1385069096.10963.2.camel@bender
State Superseded
Headers show

Commit Message

Sven Neumann Nov. 21, 2013, 9:24 p.m. UTC
Allow to compile PCRE with UTF-8/16/32 support and with
support for Unicode properties.

Signed-off-by: Sven Neumann <neumann@teufel.de>
---
 package/pcre/Config.in | 11 +++++++++++
 package/pcre/pcre.mk   |  2 ++
 2 files changed, 13 insertions(+)

Comments

Arnout Vandecappelle Nov. 21, 2013, 10:18 p.m. UTC | #1
Hi Sven,

  Thanks for your patch.

On 21/11/13 22:24, Sven Neumann wrote:
>

  Spurious empty line.

> Allow to compile PCRE with UTF-8/16/32 support and with
> support for Unicode properties.
>
> Signed-off-by: Sven Neumann <neumann@teufel.de>
> ---
>   package/pcre/Config.in | 11 +++++++++++
>   package/pcre/pcre.mk   |  2 ++
>   2 files changed, 13 insertions(+)
>
> diff --git a/package/pcre/Config.in b/package/pcre/Config.in
> index dc92274..3b93092 100644
> --- a/package/pcre/Config.in
> +++ b/package/pcre/Config.in
> @@ -19,4 +19,15 @@ config BR2_PACKAGE_PCRE_32
>   	help
>   	  This option builds the 32-bits pcre library, i.e 'libpcre32'
>
> +config BR2_PACKAGE_PCRE_UTF
> +	bool "UTF-8/16/32 support in pcre"
> +	help
> +	  This option builds the pcre library with UTF-8/16/32 support'
> +
> +config BR2_PACKAGE_PCRE_UCP
> +	bool "Unicode properties support in pcre"
> +        select BR2_PACKAGE_PCRE_UTF

  Indent with tab, not spaces.

> +	help
> +	  This option builds the pcre library with Unicode properties support (implies UTF-8/16/32 support)'

  Should be wrapped at 80 columns. [We should really document the 
wrapping guidelines...]


  With these changes, you can add my

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  (build-tested on x86_64)

> +
>   endif
> diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
> index bf86a3d..2637354 100644
> --- a/package/pcre/pcre.mk
> +++ b/package/pcre/pcre.mk
> @@ -19,5 +19,7 @@ endif
>   PCRE_CONF_OPT += --enable-pcre8
>   PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_16),--enable-pcre16,--disable-pcre16)
>   PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_32),--enable-pcre32,--disable-pcre32)
> +PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_UTF),--enable-utf,--disable-utf)
> +PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_UCP),--enable-unicode-properties,--disable-unicode-properties)
>
>   $(eval $(autotools-package))
>
diff mbox

Patch

diff --git a/package/pcre/Config.in b/package/pcre/Config.in
index dc92274..3b93092 100644
--- a/package/pcre/Config.in
+++ b/package/pcre/Config.in
@@ -19,4 +19,15 @@  config BR2_PACKAGE_PCRE_32
 	help
 	  This option builds the 32-bits pcre library, i.e 'libpcre32'
 
+config BR2_PACKAGE_PCRE_UTF
+	bool "UTF-8/16/32 support in pcre"
+	help
+	  This option builds the pcre library with UTF-8/16/32 support'
+
+config BR2_PACKAGE_PCRE_UCP
+	bool "Unicode properties support in pcre"
+        select BR2_PACKAGE_PCRE_UTF
+	help
+	  This option builds the pcre library with Unicode properties support (implies UTF-8/16/32 support)'
+
 endif
diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
index bf86a3d..2637354 100644
--- a/package/pcre/pcre.mk
+++ b/package/pcre/pcre.mk
@@ -19,5 +19,7 @@  endif
 PCRE_CONF_OPT += --enable-pcre8
 PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_16),--enable-pcre16,--disable-pcre16)
 PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_32),--enable-pcre32,--disable-pcre32)
+PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_UTF),--enable-utf,--disable-utf)
+PCRE_CONF_OPT += $(if $(BR2_PACKAGE_PCRE_UCP),--enable-unicode-properties,--disable-unicode-properties)
 
 $(eval $(autotools-package))