Patchwork [1/1] xerces: add host

login
register
mail settings
Submitter Matt Weber
Date Nov. 21, 2013, 7:48 p.m.
Message ID <1385063284-31586-1-git-send-email-mlweber1@rockwellcollins.com>
Download mbox | patch
Permalink /patch/293238/
State Rejected
Headers show

Comments

Matt Weber - Nov. 21, 2013, 7:48 p.m.
Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
---
 package/xerces/xerces.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Thomas Petazzoni - Nov. 21, 2013, 9:54 p.m.
Dear Matt Weber,

On Thu, 21 Nov 2013 13:48:04 -0600, Matt Weber wrote:
> 
> Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
> ---
>  package/xerces/xerces.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Yes, but why?

Thomas
Matt Weber - Nov. 21, 2013, 10:39 p.m.
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote on 11/21/2013 
03:54:46 PM:

> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> To: Matt Weber <mlweber1@rockwellcollins.com>
> Cc: buildroot@busybox.net
> Date: 11/21/2013 03:54 PM
> Subject: Re: [Buildroot] [PATCH 1/1] xerces: add host
> 
> Dear Matt Weber,
> 
> On Thu, 21 Nov 2013 13:48:04 -0600, Matt Weber wrote:
> > 
> > Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
> > ---
> >  package/xerces/xerces.mk |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Yes, but why?

Opps, should have included that.

I'm working on adding support for an older package called xalan that 
requires host-xerces.
However the build infrastructure in the xalan package is pretty bad and 
I'm not sure if I'll be 
able to get it cleaned up to the point of posting a patch set.  So for 
now, I've submitted 
this patch to add host-xerces support to allow us to build the xalan 
package using 
BR2_EXTERNAL until I get it hopefully cleaned up and submitted.

> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Thomas Petazzoni - Nov. 22, 2013, 8:17 a.m.
Dear Matthew Weber,

On Thu, 21 Nov 2013 16:39:01 -0600, Matthew Weber wrote:

> Opps, should have included that.
> 
> I'm working on adding support for an older package called xalan that 
> requires host-xerces.
> However the build infrastructure in the xalan package is pretty bad and 
> I'm not sure if I'll be 
> able to get it cleaned up to the point of posting a patch set.  So for 
> now, I've submitted 
> this patch to add host-xerces support to allow us to build the xalan 
> package using 
> BR2_EXTERNAL until I get it hopefully cleaned up and submitted.

Hum, okay. I'm generally not a big fan on having the host variant of
packages if they are not used by packages in Buildroot. I usually
prefer when the host variant of package A is added as part of a patch
set that allows adds package B, which depends on host-A. That being
said, I do understand the idea of upstreaming what you can for now, and
see later for the remaining things.

Best regards,

Thomas
Matt Weber - Nov. 22, 2013, 4:54 p.m.
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote on 11/22/2013 
02:17:51 AM:

> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> To: "Matthew Weber" <mlweber1@rockwellcollins.com>
> Cc: buildroot@busybox.net
> Date: 11/22/2013 02:17 AM
> Subject: Re: [Buildroot] [PATCH 1/1] xerces: add host
> 
> Dear Matthew Weber,
> 
> On Thu, 21 Nov 2013 16:39:01 -0600, Matthew Weber wrote:
> 
> > Opps, should have included that.
> > 
> > I'm working on adding support for an older package called xalan that 
> > requires host-xerces.
> > However the build infrastructure in the xalan package is pretty bad 
and 
> > I'm not sure if I'll be 
> > able to get it cleaned up to the point of posting a patch set.  So for 

> > now, I've submitted 
> > this patch to add host-xerces support to allow us to build the xalan 
> > package using 
> > BR2_EXTERNAL until I get it hopefully cleaned up and submitted.
> 
> Hum, okay. I'm generally not a big fan on having the host variant of
> packages if they are not used by packages in Buildroot. I usually
> prefer when the host variant of package A is added as part of a patch
> set that allows adds package B, which depends on host-A. That being
> said, I do understand the idea of upstreaming what you can for now, and
> see later for the remaining things.

I completely agree that it definitely isn't ideal.  I'll work on getting 
the
out of tree package upstream'd and see how bad the package cross compile 
patch set ends up.  The community around the xalan development is starting
to get a little more active so I'll see what I can get updated in their 
next release.

Thanks for the feedback!
Matt


> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Thomas Petazzoni - April 20, 2014, 9:17 p.m.
Dear Matt Weber,

On Thu, 21 Nov 2013 13:48:04 -0600, Matt Weber wrote:
> 
> Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com>
> ---
>  package/xerces/xerces.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/xerces/xerces.mk b/package/xerces/xerces.mk
> index 7bd7070..2e4c512 100644
> --- a/package/xerces/xerces.mk
> +++ b/package/xerces/xerces.mk
> @@ -25,3 +25,4 @@ XERCES_CONF_OPT += --disable-network
>  endif
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))

Since there is no package in mainline Buildroot that needs host-xerces
and that you've never submitted the other packages you mentioned back
in November, I've marked this patch as Rejected in Patchwork for now.
Do not hesitate to resend it later, together with other patches making
use of it.

Thanks!

Thomas

Patch

diff --git a/package/xerces/xerces.mk b/package/xerces/xerces.mk
index 7bd7070..2e4c512 100644
--- a/package/xerces/xerces.mk
+++ b/package/xerces/xerces.mk
@@ -25,3 +25,4 @@  XERCES_CONF_OPT += --disable-network
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))